Differential D9684

net: Add unit testing of node eviction logic
ClosedPublic
Actions

Authored by Fabien on Jun 15 2021, 10:14.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABCe284ab5f4cfe: net: Add unit testing of node eviction logic

Summary

Backport of core#20477.

Depends on D9683.

Ref T1611.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jun 15 2021, 10:14

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 15 2021, 10:14

Fabien requested review of this revision.Jun 15 2021, 10:14

teamcity edited the summary of this revision. (Show Details)Jun 15 2021, 10:14

Harbormaster completed remote builds in B16016: Diff 28920.Jun 15 2021, 10:17

Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Tail of the build log:

[329/506] Building C object src/secp256k1/CMakeFiles/sign-bench.dir/src/bench_sign.c.o
[330/506] Building C object src/secp256k1/CMakeFiles/ecmult-bench.dir/src/bench_ecmult.c.o
[331/506] Building C object src/secp256k1/CMakeFiles/recover-bench.dir/src/bench_recover.c.o
[332/506] Building C object src/secp256k1/CMakeFiles/verify-bench.dir/src/bench_verify.c.o
[333/506] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[334/506] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/consensus/tx_check.cpp.o
[335/506] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[336/506] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[337/506] Building CXX object src/CMakeFiles/common.dir/rpc/rawtransaction_util.cpp.o
[338/506] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[339/506] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[340/506] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o
[341/506] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[342/506] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[343/506] Linking C static library src/secp256k1/libsecp256k1.a
[344/506] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[345/506] Linking CXX static library src/libbitcoinconsensus.a
[346/506] Linking C executable src/secp256k1/ecmult-bench
[347/506] Linking CXX static library src/libscript.a
[348/506] Linking C executable src/secp256k1/internal-bench
[349/506] Linking C executable src/secp256k1/sign-bench
[350/506] Linking C executable src/secp256k1/verify-bench
[351/506] Linking C executable src/secp256k1/recover-bench
[352/506] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[353/506] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[354/506] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[355/506] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[356/506] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[357/506] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[358/506] Building CXX object src/CMakeFiles/common.dir/rpc/util.cpp.o
[359/506] Linking CXX static library src/libcommon.a
[360/506] Linking CXX shared library src/libbitcoinconsensus.so.0.23.6
[361/506] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[362/506] Linking CXX executable src/bitcoin-cli
[363/506] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[364/506] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[365/506] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[366/506] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[367/506] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[368/506] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[369/506] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[370/506] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[371/506] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[372/506] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[373/506] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[374/506] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[375/506] Linking CXX executable src/bitcoin-tx
[376/506] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[377/506] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[378/506] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[379/506] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[380/506] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[381/506] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[382/506] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[383/506] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[384/506] Linking CXX static library src/wallet/libwallet.a
[385/506] Linking CXX static library src/wallet/libwallet-tool.a
[386/506] Linking CXX executable src/bitcoin-wallet
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1

Fix clang-tidy

Harbormaster completed remote builds in B16017: Diff 28921.Jun 15 2021, 10:41

PiRK accepted this revision.Jun 15 2021, 12:06

This revision is now accepted and ready to land.Jun 15 2021, 12:06

Closed by commit rABCe284ab5f4cfe: net: Add unit testing of node eviction logic (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by Fabien). · Explain WhyJun 15 2021, 12:29

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCe284ab5f4cfe: net: Add unit testing of node eviction logic.