Fix mistakenly swapped lock orders in logging
ClosedPublic
Actions

Authored by PiRK on Jul 2 2021, 09:58.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC2f754a29fe1a: Fix mistakenly swapped lock orders in logging

Summary

This PR:

fixes printed lock orders

improves the sync_tests unit test

makes the "detected inconsistent lock order" error message pointing to the lock location rather tfm::format() location.

This is a backport of core#19353

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jul 2 2021, 09:58

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 2 2021, 09:58

PiRK requested review of this revision.Jul 2 2021, 09:58

teamcity edited the summary of this revision. (Show Details)Jul 2 2021, 09:58

Harbormaster completed remote builds in B16100: Diff 29052.Jul 2 2021, 10:13

majcosta accepted this revision.Jul 2 2021, 11:37

This revision is now accepted and ready to land.Jul 2 2021, 11:37

Closed by commit rABC2f754a29fe1a: Fix mistakenly swapped lock orders in logging (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhyJul 2 2021, 15:27

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC2f754a29fe1a: Fix mistakenly swapped lock orders in logging.

Revision Contents
Changeset List

Path

Size

src/

sync.cpp

21 lines

test/

sync_tests.cpp

4 lines

Diff 29053

View Options

src/sync.cpp