Page MenuHomePhabricator

Prevent setting -blockmaxsize and -excessiveblocksize <= 0
ClosedPublic

Authored by Fabien on Jul 7 2021, 09:28.

Details

Summary

This makes the init check consistent with the RPC. The GetArg() function returns an int which will then be casted to uint and might give unexpected results.

Test Plan
./test/functional/test_runner.py abc-cmdline

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix_excessiveblocksize_option
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16117
Build 32108: Build Difflint-circular-dependencies · build-without-wallet · build-debug · build-diff · build-clang · build-clang-tidy
Build 32107: arc lint + arc unit