Paths

Table of Contentst

Differential D9748

[Cashtab] icon improvements for PWA
ClosedPublic
Actions

Authored by bytesofman on Jul 7 2021, 19:57.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCd1507cac27aa: [Cashtab] icon improvements for PWA

Summary

Troubleshooting PWA icons from Lighthouse dev console report. Recommends maskable icon and apple touch icon. Added in this diff.

Test Plan

npm test. This diff only impacts icons for the PWA. Will need to re-run Lighthouse reports once the app is deployed & being served over https

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pwa-adds

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16122
Build 32118: Build Diff	cashtab-tests
Build 32117: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jul 7 2021, 19:57

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 7 2021, 19:57

bytesofman requested review of this revision.Jul 7 2021, 19:57

Harbormaster completed remote builds in B16122: Diff 29090.Jul 7 2021, 20:01

I have no way to test

This revision is now accepted and ready to land.Jul 8 2021, 09:13

Closed by commit rABCd1507cac27aa: [Cashtab] icon improvements for PWA (authored by Joey King <joseph.roy.king@gmail.com>). · Explain WhyJul 13 2021, 20:27

This revision was automatically updated to reflect the committed changes.

Joey King <joseph.roy.king@gmail.com> added a commit: rABCd1507cac27aa: [Cashtab] icon improvements for PWA.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

public/

index.html

1 line

manifest.json

3 lines

Diff 29090

View Options

web/cashtab/public/index.html