Page MenuHomePhabricator

[avalanche] More bucket brigading removal in the Processor
ClosedPublic

Authored by deadalnix on Wed, Jul 7, 21:02.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC5f1a6c2150fd: [avalanche] More bucket brigading removal in the Processor
Summary

This time, focused on FindProofForGetData. It now seems that there is a bunch of crap that is only used by tests and that the API can be dramatically reduced both in the Processor and PeerManager.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Tail of the build log:

/work /work/abc-ci-builds/lint-circular-dependencies
A new circular dependency in the form of "avalanche/peermanager -> net_processing -> avalanche/peermanager" appears to have been introduced.

/work/abc-ci-builds/lint-circular-dependencies
Build lint-circular-dependencies failed with exit code 1
deadalnix retitled this revision from [avalanche] More rbucket brigading removal in the Processor to [avalanche] More bucket brigading removal in the Processor.Wed, Jul 7, 21:12

Why does the peer manager depends on et processing?

Rebase on D9751 to remove circular dependency

Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/avalanche/peermanager.cpp
130 ↗(On Diff #29097)

The processor addProof method can be updated to take advantage of this

This revision is now accepted and ready to land.Thu, Jul 8, 08:57
src/avalanche/processor.cpp
574 ↗(On Diff #29097)

It does, no?

src/avalanche/processor.cpp
574 ↗(On Diff #29097)

Missed it, my bad