[avalanche] More bucket brigading removal in the Processor
ClosedPublic
Actions

Authored by deadalnix on Jul 7 2021, 21:02.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC5f1a6c2150fd: [avalanche] More bucket brigading removal in the Processor

Summary

This time, focused on FindProofForGetData. It now seems that there is a bunch of crap that is only used by tests and that the API can be dramatically reduced both in the Processor and PeerManager.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

peermanagercleanup2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16123
Build 32120: Build Diff	build-clang-tidy · build-without-wallet · lint-circular-dependencies · build-debug · build-clang · build-diff
Build 32119: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 7 2021, 21:02

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 7 2021, 21:02

deadalnix requested review of this revision.Jul 7 2021, 21:02

Harbormaster completed remote builds in B16123: Diff 29091.Jul 7 2021, 21:04

Build Bitcoin ABC Diffs / Diff Testing (lint-circular-dependencies) failed.

Tail of the build log:

/work /work/abc-ci-builds/lint-circular-dependencies
A new circular dependency in the form of "avalanche/peermanager -> net_processing -> avalanche/peermanager" appears to have been introduced.

/work/abc-ci-builds/lint-circular-dependencies
Build lint-circular-dependencies failed with exit code 1

deadalnix retitled this revision from [avalanche] More rbucket brigading removal in the Processor to [avalanche] More bucket brigading removal in the Processor.Jul 7 2021, 21:12

Why does the peer manager depends on et processing?

Rebase on D9751 to remove circular dependency

Harbormaster completed remote builds in B16129: Diff 29097.Jul 8 2021, 00:55

Fabien accepted this revision.Jul 8 2021, 08:57

Fabien added a subscriber: Fabien.

Fabien added inline comments.