Page MenuHomePhabricator

functional tests: Remove portseed_offset from test runner
ClosedPublic

Authored by PiRK on Thu, Jul 8, 15:03.

Details

Summary

PR description:

The portseed_offset is no longer needed in the test runner, since we already kill leftover processes

The pseudo-random portseed causes port collisions with other daemons. Core devs had issues with port 11211 (memcached), and we are seeing issues with 21325 (trezord).
This backport is a first step in avoiding random failures, by making the ports more deterministic again.

We cannot use the number of tests as a unique seed for Bitcoin ABC like Core does, because we run tests in parallel, so use the test number instead.

This is a backport of core#13421

Test Plan

for i in {1..4}; do ninja check-functional; done

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Thu, Jul 8, 15:03
PiRK retitled this revision from qa: Remove portseed_offset from test runner to functional tests: Remove portseed_offset from test runner.Thu, Jul 8, 15:14
This revision is now accepted and ready to land.Thu, Jul 8, 15:21