Page MenuHomePhabricator
Differential D9762

[avalanche] add a test for a node started with an orphan proof
AbandonedPublic
Actions

Authored by PiRK on Jul 9 2021, 16:06.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Summary

This will be a common case: someone spinning up a new node from scratch
with a proof build by another node or by a wallet. The new node will
initially not have the blockchain and consider the proof to be orphan.

Depends on D9742

Test Plan

ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
register_proof
Lint
Lint Errors
SeverityLocationCodeMessage
Errortest/functional/abc_rpc_avalancheproof.py:55E231flake8 E231
Unit
No Test Coverage
Build Status
Buildable 16146
Build 32165: Build Diffbuild-debug · build-diff · build-clang · build-without-wallet · build-clang-tidy
Build 32164: arc lint + arc unit

Event Timeline

PiRK created this revision.Jul 9 2021, 16:06
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 9 2021, 16:06
PiRK requested review of this revision.Jul 9 2021, 16:06
Harbormaster completed remote builds in B16146: Diff 29128.Jul 9 2021, 16:06
PiRK updated this revision to Diff 29129.Jul 9 2021, 16:08

address linter error

Harbormaster completed remote builds in B16147: Diff 29129.Jul 9 2021, 16:28
deadalnix requested changes to this revision.Jul 10 2021, 13:34
deadalnix added a subscriber: deadalnix.

I think that should be merged in D9742 . it doesn't make much sense to separate the code and the tests.

This revision now requires changes to proceed.Jul 10 2021, 13:34
PiRK mentioned this in D9742: [avalanche] register local proof at first tip update.Jul 12 2021, 07:34
PiRK abandoned this revision.Jul 12 2021, 07:34

merged with D9742

Revision Contents
Changeset List

PathSize
test/
functional/
32 lines

Diff 29128

View Options

test/functional/abc_rpc_avalancheproof.py

Loading...