Page MenuHomePhabricator
Differential D979

Make forknotify.py more robust
ClosedPublic
Actions

Authored by matiu on Jan 18 2018, 03:54.

Details

Reviewers
deadalnix
schancel
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Maniphest Tasks
T144: Backport for PR 10072: Remove sources of unreliablility in extended functional tests
Commits
rSTAGINGf42bb363128c: Make forknotify.py more robust
rABCf42bb363128c: Make forknotify.py more robust
Summary

Backport from https://github.com/bitcoin/bitcoin/commit/a4fd89fddba49c56e77f131fe95feffa8d7cf6ed

Fixes T144 / T145

(a4fd89f backported here)
(1f3d78b already backported at D972)

Test Plan

./test/functional/test_runner.py forknotify

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

matiu created this revision.Jan 18 2018, 03:54
Owners added a reviewer: Restricted Owners Package.Jan 18 2018, 03:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 18 2018, 03:54
matiu edited the summary of this revision. (Show Details)Jan 18 2018, 03:56
matiu added a task: T144: Backport for PR 10072: Remove sources of unreliablility in extended functional tests.
matiu retitled this revision from Fix conflicts with alertnotify to Make forknotify.py more robust.Jan 18 2018, 04:07
matiu edited the summary of this revision. (Show Details)
matiu mentioned this in T145: Port core PR10072.
deadalnix requested changes to this revision.Jan 18 2018, 14:18
deadalnix added inline comments.
test/functional/forknotify.py
50 ↗(On Diff #2577)

You missed that part. You should really use cherry pick instead of trying to reproduce the diff manually.

This revision now requires changes to proceed.Jan 18 2018, 14:18
matiu updated this revision to Diff 2578.Jan 18 2018, 16:23
matiu retitled this revision from Make forknotify.py more robust to Make forknotify.py more robust.

update diff with missing changes.

deadalnix accepted this revision.Jan 18 2018, 17:03
This revision is now accepted and ready to land.Jan 18 2018, 17:03
Closed by commit rABCf42bb363128c: Make forknotify.py more robust (authored by John Newbery <john@johnnewbery.com>, committed by matiu). · Explain WhyJan 19 2018, 15:58
This revision was automatically updated to reflect the committed changes.
matiu marked an inline comment as done.
schancel mentioned this in T144: Backport for PR 10072: Remove sources of unreliablility in extended functional tests.Jan 20 2018, 20:10

Revision Contents
Changeset List

PathSize
test/
functional/
18 lines

Diff 2595

View Options

test/functional/forknotify.py

Loading...