Differential D9792

[avalanche] Supply an optional delegation to the addavalanchenode RPC
ClosedPublic
Actions

Authored by Fabien on Jul 15 2021, 13:26.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABC2c0e8b892205: [avalanche] Supply an optional delegation to the addavalanchenode RPC

Summary

This makes it possible to manually add a node that doesn't have access to the proof master private key for signing the messages.

Ref T1635.

Test Plan

./test/functional/test_runner.py abc_rpc_addavalanchenode

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_addavalanchenode_rpc

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16191
Build 32255: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-clang-tidy · build-debug · build-clang
Build 32254: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 15 2021, 13:26

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 15 2021, 13:26

Fabien requested review of this revision.Jul 15 2021, 13:26

Harbormaster completed remote builds in B16189: Diff 29199.Jul 15 2021, 13:41

Fabien planned changes to this revision.Jul 15 2021, 14:16

Consistently use named args

Fabien added a child revision: D9793: [avalanche] Improve error messages from the addavalanchenode RPC.Jul 15 2021, 14:21

Harbormaster completed remote builds in B16191: Diff 29202.Jul 15 2021, 14:32

PiRK accepted this revision.Jul 15 2021, 15:16

This revision is now accepted and ready to land.Jul 15 2021, 15:16

Closed by commit rABC2c0e8b892205: [avalanche] Supply an optional delegation to the addavalanchenode RPC (authored by Fabien). · Explain WhyJul 16 2021, 11:17

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC2c0e8b892205: [avalanche] Supply an optional delegation to the addavalanchenode RPC.

Revision Contents
Changeset List

Path

Size

src/

rpc/

avalanche.cpp

53 lines

test/

functional/

abc_rpc_addavalanchenode.py

97 lines

Diff 29202

View Options

src/rpc/avalanche.cpp