Page MenuHomePhabricator

Rebrand comments from C++ source files
ClosedPublic

Authored by Fabien on Jul 19 2021, 15:17.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Maniphest Tasks
T1672: Node software rebrand
Commits
rABC92bd0b213b64: Rebrand comments from C++ source files
Summary

As per title.

Ref T1672.

Test Plan

Read the comments.

arc lint

Diff Detail

Event Timeline

Fabien requested review of this revision.Jul 19 2021, 15:17
majcosta requested changes to this revision.Jul 19 2021, 18:17
majcosta added a subscriber: majcosta.
majcosta added inline comments.
src/amount.h
169 ↗(On Diff #29235)

this is confusing, maybe it's better to say COIN rather than XEC because when our default unit was the same as our ticker, BCH the comment made sense, but with XEC it isn't immediately clear.

src/qt/test/paymentrequestdata.h
433 ↗(On Diff #29235)

There is no MegXEC unit in the codebase, here you probably want to spell out the 21,000,001,000,000

This revision now requires changes to proceed.Jul 19 2021, 18:17
This revision is now accepted and ready to land.Jul 20 2021, 14:47
This revision was automatically updated to reflect the committed changes.