Page MenuHomePhabricator

Rebrand the comments in wallet_avoidreuse.py
ClosedPublic

Authored by Fabien on Mon, Jul 19, 15:19.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABCa9872acb6f0d: Rebrand the comments in wallet_avoidreuse.py
Summary

This one has a lot of comments affected, so put it into review alone.

Ref T1672.

Test Plan
./test/functional/test_runner.py wallet_avoidreuse.py

Read the comments.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.Mon, Jul 19, 15:20
majcosta requested changes to this revision.Mon, Jul 19, 18:36
majcosta added a subscriber: majcosta.

what about abbreviating the million? I read that 'MM' is most common than 'm' or 'mil' so, use 1MM XEC instead of 1,000,000 seems to nicely avoid unnecessary zeroes

This revision now requires changes to proceed.Mon, Jul 19, 18:36
This revision is now accepted and ready to land.Tue, Jul 20, 14:45
This revision was automatically updated to reflect the committed changes.