Page MenuHomePhabricator

Rebrand the comments in wallet_avoidreuse.py
ClosedPublic

Authored by Fabien on Jul 19 2021, 15:19.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Maniphest Tasks
T1672: Node software rebrand
Commits
rABCa9872acb6f0d: Rebrand the comments in wallet_avoidreuse.py
Summary

This one has a lot of comments affected, so put it into review alone.

Ref T1672.

Test Plan
./test/functional/test_runner.py wallet_avoidreuse.py

Read the comments.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
rebrand_wallet_avoidreuse
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16217
Build 32303: Build Diffbuild-without-wallet · build-diff · build-debug · build-clang · build-clang-tidy
Build 32302: arc lint + arc unit

Event Timeline

Fabien requested review of this revision.Jul 19 2021, 15:20
majcosta requested changes to this revision.Jul 19 2021, 18:36
majcosta added a subscriber: majcosta.

what about abbreviating the million? I read that 'MM' is most common than 'm' or 'mil' so, use 1MM XEC instead of 1,000,000 seems to nicely avoid unnecessary zeroes

This revision now requires changes to proceed.Jul 19 2021, 18:36
This revision is now accepted and ready to land.Jul 20 2021, 14:45
This revision was automatically updated to reflect the committed changes.