Page MenuHomePhabricator

make copyright headers more consistent
ClosedPublic

Authored by PiRK on Tue, Jul 20, 09:21.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC5e1ee2503a55: make copyright headers more consistent
Summary

"The Bitcoin developers" and "The Bitcoin Core developers" is the
dominant use. Fix the few occurences of "Developers" (capital D).

Remove one occurence of a "-" between the authors and the year, and one extra "-" after the first year.

Replace "Bitcoin developers" with "The Bitcoin developers" in one file.

Test Plan

Before:

$./contrib/devtools/copyright_header.py report .
34 with unexpected copyright holder names

After:

$./contrib/devtools/copyright_header.py report .
27 with unexpected copyright holder names

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Tue, Jul 20, 09:21
PiRK edited the summary of this revision. (Show Details)
PiRK edited the test plan for this revision. (Show Details)

remove also a "-" that the copyright headers script cannot handle

PiRK edited the summary of this revision. (Show Details)
PiRK edited the test plan for this revision. (Show Details)

fix another discrepency with an extra dash

PiRK edited the summary of this revision. (Show Details)
PiRK edited the test plan for this revision. (Show Details)

fix also sighastype.h (missing "The")

I don't think you have the right to change the copyright from previous contributors, but I'm no expert and maybe a small case change like this is OK.

This revision is now accepted and ready to land.Tue, Jul 20, 18:05
This revision was automatically updated to reflect the committed changes.