Page MenuHomePhabricator
Differential D9816

make copyright headers more consistent
ClosedPublic
Actions

Authored by PiRK on Jul 20 2021, 09:21.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC5e1ee2503a55: make copyright headers more consistent
Summary

"The Bitcoin developers" and "The Bitcoin Core developers" is the
dominant use. Fix the few occurences of "Developers" (capital D).

Remove one occurence of a "-" between the authors and the year, and one extra "-" after the first year.

Replace "Bitcoin developers" with "The Bitcoin developers" in one file.

Test Plan

Before:

$./contrib/devtools/copyright_header.py report .
34 with unexpected copyright holder names

After:

$./contrib/devtools/copyright_header.py report .
27 with unexpected copyright holder names

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Jul 20 2021, 09:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 20 2021, 09:21
PiRK requested review of this revision.Jul 20 2021, 09:21
PiRK updated this revision to Diff 29255.Jul 20 2021, 09:24
PiRK edited the summary of this revision. (Show Details)
PiRK edited the test plan for this revision. (Show Details)

remove also a "-" that the copyright headers script cannot handle

PiRK updated this revision to Diff 29256.Jul 20 2021, 09:28
PiRK edited the summary of this revision. (Show Details)
PiRK edited the test plan for this revision. (Show Details)

fix another discrepency with an extra dash

Harbormaster completed remote builds in B16225: Diff 29254.Jul 20 2021, 09:41
Harbormaster completed remote builds in B16226: Diff 29255.Jul 20 2021, 09:50
Harbormaster completed remote builds in B16227: Diff 29256.Jul 20 2021, 09:54
PiRK updated this revision to Diff 29263.Jul 20 2021, 09:56
PiRK edited the summary of this revision. (Show Details)
PiRK edited the test plan for this revision. (Show Details)

fix also sighastype.h (missing "The")

Fabien added a subscriber: Fabien.Jul 20 2021, 10:05

I don't think you have the right to change the copyright from previous contributors, but I'm no expert and maybe a small case change like this is OK.

Harbormaster completed remote builds in B16229: Diff 29263.Jul 20 2021, 10:29
majcosta accepted this revision.Jul 20 2021, 18:05
This revision is now accepted and ready to land.Jul 20 2021, 18:05
Closed by commit rABC5e1ee2503a55: make copyright headers more consistent (authored by PiRK). · Explain WhyJul 21 2021, 12:10
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC5e1ee2503a55: make copyright headers more consistent.

Revision Contents
Changeset List

PathSize
2 lines
contrib/
debian/
6 lines
src/
2 lines
2 lines
qt/
test/
2 lines
2 lines
script/
2 lines
test/
2 lines

Diff 29289

View Options

COPYING

Loading...
View Options

contrib/debian/copyright

Loading...
View Options

src/currencyunit.h

Loading...
View Options

src/currencyunit.cpp

Loading...
View Options

src/qt/test/bitcoinaddressvalidatortests.h

Loading...
View Options

src/qt/test/bitcoinaddressvalidatortests.cpp

Loading...
View Options

src/script/scriptcache.h

Loading...
View Options

src/test/sigcache_tests.cpp

Loading...