Page MenuHomePhabricator

[LINTER] Handle errors from the Prettier linter
ClosedPublic

Authored by Fabien on Jul 26 2021, 18:25.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABCcaa8bdd07091: [LINTER] Handle errors from the Prettier linter
Summary

When the linter returns an error, it crashes arcanist (at best). This diff catches the error and return it as part of the linter output. Since the output can vary a lot there is no regex involved, just a raw dump a stderr.

Test Plan

Edit some .json file to make it seriously invalid (like adding a unexpected bracket), then run arc lint and check there is no crash and the error is reported.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable