Do not specify a line/char for prettier when not apropriate
ClosedPublic
Actions

Authored by deadalnix on Jul 27 2021, 13:32.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC4c8d559ef552: Do not specify a line/char for prettier when not apropriate

Summary

This makes the output super weird for no reason whatsoever as orettier error messages already point to the right location.

I also fixed the indentation that was weird. I was unable to run phpcs as it exploded in my face, so I ended up not.

Test Plan

Edit web/docs/package.json to make it invalid.
Run arc lint
Check the output makes more sense.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

prettierbug

Lint

Lint Skipped

Unit

No Test Coverage

Build Status

Buildable 16259
Build 32385: Build Diff
Build 32384: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 27 2021, 13:32

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 27 2021, 13:32

deadalnix requested review of this revision.Jul 27 2021, 13:33

Harbormaster completed remote builds in B16259: Diff 29314.Jul 27 2021, 13:33

Fabien accepted this revision.Jul 27 2021, 14:04

This revision is now accepted and ready to land.Jul 27 2021, 14:04

Closed by commit rABC4c8d559ef552: Do not specify a line/char for prettier when not apropriate (authored by deadalnix). · Explain WhyJul 27 2021, 14:18

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC4c8d559ef552: Do not specify a line/char for prettier when not apropriate.

Revision Contents
Changeset List

Path

Size

arcanist/

linter/

PrettierLinter.php

34 lines

Diff 29314

View Options

arcanist/linter/PrettierLinter.php

Do not specify a line/char for prettier when not apropriateClosedPublicActions