Page MenuHomePhabricator

[cashtab] Remove fbt and I18n from app and extension
ClosedPublic

Authored by alcipir on Jul 27 2021, 15:07.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABCb770eba90ae9: [cashtab] Remove fbt and I18n from app and extension
Summary

Remove fbt and I18n from app and extension.

Test Plan

npm install && npm run test && npm start

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cashtab-remove-intl
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16283
Build 32433: Build Diffcashtab-tests
Build 32432: arc lint + arc unit

Event Timeline

alcipir requested review of this revision.Jul 27 2021, 15:07
bytesofman added a subscriber: bytesofman.

Looks good. This is an important step in preparation for upgrading to webpack 5 and continuing to simplify the dependency tree.

Because

(1) localization is not actively being used
(2) localization has not been looked at for about a year now

I think we should optimize and implement localization after we have upgraded webpack, rather than drag this through the process (and potentially pull it out later).

This revision is now accepted and ready to land.Jul 27 2021, 17:24