Page MenuHomePhabricator
Differential D9847

[avalanche] Return node statistics in the getavalanchepeerinfo RPC
AbandonedPublic
Actions

Authored by Fabien on Aug 4 2021, 15:19.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Summary

Note that this required a modification of the processor so the cs_peermanager lock is not hold when cs_vNodes is locked, which would cause a lock order inversion (and an effective deadlock) when calling the RPC.

Ref T1634.

Depends on D9839 and D9846.

Test Plan

With debug:

ninja all check-all

Diff Detail

Event Timeline

Fabien created this revision.Aug 4 2021, 15:19
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 4 2021, 15:19
Fabien requested review of this revision.Aug 4 2021, 15:19
Harbormaster completed remote builds in B16270: Diff 29330.Aug 4 2021, 15:34
deadalnix requested changes to this revision.Aug 4 2021, 21:45
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/avalanche/processor.cpp
717

This is clearly not workable, we want to make sure this happens BEFORE the message is sent.

This revision now requires changes to proceed.Aug 4 2021, 21:45
Fabien abandoned this revision.Aug 9 2021, 15:00

Revision Contents
Changeset List

PathSize
src/
avalanche/
12 lines
rpc/
39 lines
test/
functional/
7 lines

Diff 29330

View Options

src/avalanche/processor.cpp

Loading...
View Options

src/rpc/avalanche.cpp

Loading...
View Options

test/functional/abc_rpc_getavalanchepeerinfo.py

Loading...