Page MenuHomePhabricator

[Cashtab] remove price api order of magnitude error check
ClosedPublic

Authored by bytesofman on Aug 5 2021, 20:08.

Details

Summary

This error check was put in place in case Coingecko changed their endpoint to offer XEC price instead of BCHA. However, Coingecko is providing 2 separate endpoints, so that risk is much lower. Also, the entire app will move to the XEC endpoint soon.

The main purpose of this diff is to support more fiat currencies. This order of magnitude check always throws an error for currencies that are an order of magnitude off from USD, such as Vietnamese Dong.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
remove-api-magnitude-check
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16275
Build 32417: Build Diffcashtab-tests
Build 32416: arc lint + arc unit