This makes it possible to remove the net_processing.h header from the processor.
This is a step toward reducing the coupling between the avalanche and network layers.
Ref T1634.
Details
Details
- Reviewers
majcosta - Group Reviewers
Restricted Project - Maniphest Tasks
- Restricted Maniphest Task
- Commits
- rABC28d7e648ffc5: [avalanche] Remove the (node) PeerManager member from the avalanche processor
ninja all check-all ./contrib/teamcity/build-configurations.py lint-circular-dependencies
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| src/avalanche/processor.h | ||
|---|---|---|
| 270–272 ↗ | (On Diff #29343) | this interface would probably make the rest of the diff a lot simpler |
| src/net_processing.cpp | ||
| 4362–4366 ↗ | (On Diff #29343) | for example, here: |
Comment Actions
I don't think this makes the API more clear: you need to special case part of the returned value to determine if the call was successful while a bool is straightforward. This is also more consistent with the other parts of the codebase.