Page MenuHomePhabricator
Differential D9863

Introduce EraseLastKElementsIf to simplify the node eviction code
ClosedPublic
Actions

Authored by Fabien on Aug 10 2021, 13:18.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABC1f07a6833500: Introduce EraseLastKElementsIf to simplify the node eviction code
Summary

There is a redundant pattern in the SelectNodeToEvict algorithm, which can be fatorized to make the code easier to follow.

There is no change in behavior.

Ref T1634.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Aug 10 2021, 13:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 10 2021, 13:18
Fabien requested review of this revision.Aug 10 2021, 13:18
deadalnix accepted this revision.Aug 10 2021, 13:26
This revision is now accepted and ready to land.Aug 10 2021, 13:26
Fabien retitled this revision from Introduce EraseLastKElementsIf to siimplify the node eviction code to Introduce EraseLastKElementsIf to simplify the node eviction code.Aug 10 2021, 13:29
Harbormaster completed remote builds in B16297: Diff 29371.Aug 10 2021, 13:31
Closed by commit rABC1f07a6833500: Introduce EraseLastKElementsIf to simplify the node eviction code (authored by Fabien). · Explain WhyAug 10 2021, 13:51
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC1f07a6833500: Introduce EraseLastKElementsIf to simplify the node eviction code.
Fabien mentioned this in D9857: [avalanche] Protect nodes with high availability score from eviction.Aug 10 2021, 13:57
PiRK mentioned this in D10979: Refactor EraseLastKElements to be a special case of EraseLastKElementsIf.Feb 3 2022, 15:20
PiRK mentioned this in rABC443b5d94aef2: Refactor EraseLastKElements to be a special case of EraseLastKElementsIf.Feb 4 2022, 11:00

Revision Contents
Changeset List

PathSize
src/
40 lines

Diff 29372

View Options

src/net.cpp

Loading...