[Cashtab] Remove support for sending to BCH or SLP addresses
ClosedPublic
Actions

Authored by bytesofman on Aug 17 2021, 20:28.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC77a08f47e6d4: [Cashtab] Remove support for sending to BCH or SLP addresses

Summary

T1735

Remove support for sending to addresses with bitcoincash: or simpleledger: prefixes, even if they are valid cashaddr.

This diff also modifies validation so that xec must be sent to an ecash: prefixed address and eTokens must be sent to an etoken: prefixed address.

Test Plan

npm start, try to send XEC to a bitcoincash: prefixed address and an etoken: prefixed address and note validation, try to send eToken to simpleledger: prefixed address and ecash: prefixed address and note validation

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Aug 17 2021, 20:28

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 17 2021, 20:28

bytesofman requested review of this revision.Aug 17 2021, 20:28

Harbormaster completed remote builds in B16333: Diff 29425.Aug 17 2021, 20:31

majcosta accepted this revision.Aug 17 2021, 22:49

majcosta added a subscriber: majcosta.

majcosta added inline comments.

web/cashtab/src/components/Common/Ticker.js
134 ↗	(On Diff #29425)	no need to pass a string here, just use a boolean, `isToken = false` or something
web/cashtab/src/components/Send/SendToken.js
199 ↗	(On Diff #29425)	if the function signature is made to be self-documenting, this additional comment is superfluous