Page MenuHomePhabricator

[Cashtab] Remove unused artifact params from Send.js
ClosedPublic

Authored by bytesofman on Aug 17 2021, 22:32.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC4719dcc5935d: [Cashtab] Remove unused artifact params from Send.js
Summary

T1724

The Send.js screen accepts two props --- filledAddress and callbackTxid --- that are never used in Cashtab. These are artifacts of the original Mint codebase where the Send component was a pop-up that could be called in different contexts, e.g. to send dividend payments.

Cashtab has diverged so much from Mint at this point that even if similar functionality were to be built back in, it would not use this same approach. Therefore they should be removed as they are baffling to anyone without a familiarity with the entire history of the codebase.

Test Plan

npm start and send an XEC transaction

Diff Detail

Repository
rABC Bitcoin ABC
Branch
remove-artifact-params
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16335
Build 32533: Build Diffcashtab-tests
Build 32532: arc lint + arc unit