Paths

Table of Contentst

Differential D9894

[Cashtab] Remove legacy walletState parameter
ClosedPublic
Actions

Authored by bytesofman on Aug 22 2021, 22:16.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABCe4e479aeb4b3: [Cashtab] Remove legacy walletState parameter

Summary

T1742

Remove legacy walletState parameter.

walletState was replaced by wallet.state to enable local storage support for utxo set and token balances, speeding up Cashtab.

This was already done in every screen using wallet.state. This diff completes the deprecation of walletState by removing it from useWallet.js (where it was still used for incoming tx notifications)

Test Plan

npm start
Receive an XEC tx and note tx notification
Receive an eToken tx and note tx notification

Diff Detail

Repository

rABC Bitcoin ABC

Branch

remove-legacy-walletState

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16359
Build 32581: Build Diff	cashtab-tests
Build 32580: arc lint + arc unit

Event Timeline

bytesofman created this revision.Aug 22 2021, 22:16

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 22 2021, 22:16

bytesofman requested review of this revision.Aug 22 2021, 22:16

Harbormaster completed remote builds in B16359: Diff 29462.Aug 22 2021, 22:20

majcosta accepted this revision.Aug 23 2021, 18:11

This revision is now accepted and ready to land.Aug 23 2021, 18:11

Closed by commit rABCe4e479aeb4b3: [Cashtab] Remove legacy walletState parameter (authored by Joey King <joseph.roy.king@gmail.com>). · Explain WhyAug 23 2021, 18:20

This revision was automatically updated to reflect the committed changes.

Joey King <joseph.roy.king@gmail.com> added a commit: rABCe4e479aeb4b3: [Cashtab] Remove legacy walletState parameter.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

hooks/

useWallet.js

40 lines

Diff 29462

View Options

web/cashtab/src/hooks/useWallet.js

[Cashtab] Remove legacy walletState parameterClosedPublicActions