Page MenuHomePhabricator

[Cashtab] Support token tx parsing from HD wallet
ClosedPublic

Authored by bytesofman on Aug 23 2021, 21:49.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABCdb528f54ba85: [Cashtab] Support token tx parsing from HD wallet
Summary

T1767

Cashtab incorrectly parses incoming eToken txs by assuming any input that is not change was sent to the receiving wallet. This only works for the narrow case of non-HD wallets, i.e. Cashtab itself, which is how this bug originated.

This diff only counts tokenQty received at the receiving address as received. Unit test added to confirm.

Test Plan

npm start
Receive eToken txs from an HD-supporting eToken wallet, e.g. RaiPay
Note tx history parses correctly

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable