HomePhabricator

[Cashtab] Support token tx parsing from HD wallet

Description

[Cashtab] Support token tx parsing from HD wallet

Summary:
T1767

Cashtab incorrectly parses incoming eToken txs by assuming any input that is not change was sent to the receiving wallet. This only works for the narrow case of non-HD wallets, i.e. Cashtab itself, which is how this bug originated.

This diff only counts tokenQty received at the receiving address as received. Unit test added to confirm.

Test Plan:
npm start
Receive eToken txs from an HD-supporting eToken wallet, e.g. RaiPay
Note tx history parses correctly

Reviewers: #bitcoin_abc, majcosta

Reviewed By: #bitcoin_abc, majcosta

Differential Revision: https://reviews.bitcoinabc.org/D9913

Details

Provenance
Joey King <joseph.roy.king@gmail.com>Authored on Aug 23 2021, 21:47
bytesofmanPushed on Aug 24 2021, 00:09
Reviewer
Restricted Project
Differential Revision
D9913: [Cashtab] Support token tx parsing from HD wallet
Parents
rABCd4672f7daee7: [Cashtab] Remove legacy utxos state field from useWallet.js
Branches
Unknown
Tags
Unknown