Page MenuHomePhabricator
Differential D9934

[tests] move generate_wif_key to wallet_util.py
ClosedPublic
Actions

Authored by PiRK on Aug 25 2021, 09:09.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC466aa70881ec: [tests] move generate_wif_key to wallet_util.py
Summary

generate_wif_key is a wallet utility function. Move
it from the EC key module to the wallet util module.

This is a backport of core#19239

Backport note: the revert commit is not relevant, we haven't backported core#19230

Test Plan

ninja check-functional-extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr19239
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16413
Build 32689: Build Diff
Build 32688: arc lint + arc unit

Event Timeline

PiRK created this revision.Aug 25 2021, 09:09
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 25 2021, 09:09
PiRK requested review of this revision.Aug 25 2021, 09:09
teamcity edited the summary of this revision. (Show Details)Aug 25 2021, 09:09
Harbormaster completed remote builds in B16411: Diff 29549.Aug 25 2021, 09:19
majcosta accepted this revision.Aug 25 2021, 09:28
This revision is now accepted and ready to land.Aug 25 2021, 09:28
PiRK updated this revision to Diff 29555.Aug 25 2021, 09:50

I forgot to squash the commits (it was missinng sorting the imports in a file)

Harbormaster completed remote builds in B16413: Diff 29555.Aug 25 2021, 09:51
This revision was landed with ongoing or failed builds.Aug 25 2021, 10:59
Closed by commit rABC466aa70881ec: [tests] move generate_wif_key to wallet_util.py (authored by John Newbery <john@johnnewbery.com>, committed by PiRK). · Explain Why
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC466aa70881ec: [tests] move generate_wif_key to wallet_util.py.
PiRK mentioned this in D10213: Add a --descriptors option to various tests.Sep 29 2021, 13:57
PiRK mentioned this in rABCe854278f6db0: Add a --descriptors option to various tests.Oct 5 2021, 08:38

Revision Contents
Changeset List

Diff 29555

View Options

test/functional/abc_p2p_avalanche_peer_discovery.py

Loading...
View Options

test/functional/abc_p2p_proof_inventory.py

Loading...
View Options

test/functional/abc_rpc_avalancheproof.py

Loading...
View Options

test/functional/p2p_eviction.py

Loading...
View Options

test/functional/p2p_inv_download.py

Loading...
View Options

test/functional/rpc_createmultisig.py

Loading...
View Options

test/functional/test_framework/key.py

Loading...
View Options

test/functional/test_framework/wallet_util.py

Loading...