Differential D9938

Make SeparatorStyle a scoped enum
ClosedPublic
Actions

Authored by PiRK on Aug 25 2021, 13:01.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABCb75671eabcbc: Make SeparatorStyle a scoped enum

Summary

This is a backport of core-gui#3

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

gui_pr3

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16416
Build 32695: Build Diff	lint-circular-dependencies · build-debug · build-without-wallet · build-clang-tidy · build-diff · build-clang
Build 32694: arc lint + arc unit

Event Timeline

PiRK created this revision.Aug 25 2021, 13:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 25 2021, 13:01

PiRK requested review of this revision.Aug 25 2021, 13:01

Harbormaster completed remote builds in B16416: Diff 29559.Aug 25 2021, 13:15

PiRK edited the summary of this revision. (Show Details)Aug 25 2021, 16:32

PiRK edited the summary of this revision. (Show Details)Aug 25 2021, 16:34

majcosta accepted this revision.Aug 26 2021, 07:09

This revision is now accepted and ready to land.Aug 26 2021, 07:09

Closed by commit rABCb75671eabcbc: Make SeparatorStyle a scoped enum (authored by PiRK). · Explain WhyAug 26 2021, 08:06

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCb75671eabcbc: Make SeparatorStyle a scoped enum.

Revision Contents
Changeset List

Path

Size

src/

qt/

bitcoinamountfield.cpp

11 lines

8 lines

4 lines

8 lines

41 lines

recentrequeststablemodel.cpp

2 lines

test/

wallettests.cpp

4 lines

transactiontablemodel.h

2 lines

transactiontablemodel.cpp

9 lines

Diff 29559

View Options

src/qt/bitcoinamountfield.cpp

View Options

src/qt/bitcoinunits.h

View Options

src/qt/bitcoinunits.cpp

View Options

src/qt/guiutil.cpp

View Options

src/qt/overviewpage.cpp

View Options

src/qt/recentrequeststablemodel.cpp

View Options

src/qt/test/wallettests.cpp

View Options

src/qt/transactiontablemodel.h

View Options

src/qt/transactiontablemodel.cpp

Make SeparatorStyle a scoped enumClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 29559

src/qt/bitcoinamountfield.cpp

src/qt/bitcoinunits.h

src/qt/bitcoinunits.cpp

src/qt/guiutil.cpp

src/qt/overviewpage.cpp

src/qt/recentrequeststablemodel.cpp

src/qt/test/wallettests.cpp

src/qt/transactiontablemodel.h

src/qt/transactiontablemodel.cpp

Make SeparatorStyle a scoped enum
ClosedPublic
Actions

Revision Contents
Changeset List