rpc: make generatetoaddress locals const
ClosedPublic
Actions

Authored by PiRK on Aug 25 2021, 16:18.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABCbc48276efe95: rpc: make generatetoaddress locals const

Summary

and named the same as in generatetodescriptor just above.

This is a backport of core#19133 [2/10]
https://github.com/bitcoin/bitcoin/pull/19133/commits/9be7fd35c5d631c2cc34d3b4fa63ae0a9d5a68ef

Backport note: we use get_int64 instead of get_int for max_tries because of D7138

Depends on D9941

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16420
Build 32703: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 32702: arc lint + arc unit

Event Timeline

PiRK created this revision.Aug 25 2021, 16:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 25 2021, 16:18

PiRK requested review of this revision.Aug 25 2021, 16:18

teamcity edited the summary of this revision. (Show Details)Aug 25 2021, 16:18

PiRK added a child revision: D9943: cli: create GetNewAddress().Aug 25 2021, 16:19

Harbormaster completed remote builds in B16420: Diff 29564.Aug 25 2021, 16:38

majcosta accepted this revision.Aug 26 2021, 07:20

This revision is now accepted and ready to land.Aug 26 2021, 07:20

Closed by commit rABCbc48276efe95: rpc: make generatetoaddress locals const (authored by Jon Atack <jon@atack.com>, committed by PiRK). · Explain WhyAug 26 2021, 08:10

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCbc48276efe95: rpc: make generatetoaddress locals const.

Revision Contents
Changeset List

Path

Size

src/

rpc/

mining.cpp

13 lines

Diff 29564

View Options

rpc: make generatetoaddress locals constClosedPublicActions