Paths

Table of Contentst

Differential D9959

scheduler: Replace stop(true) with StopWhenDrained()
ClosedPublic
Actions

Authored by PiRK on Aug 26 2021, 14:54.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC4526add5399a: scheduler: Replace stop(true) with StopWhenDrained()

Summary

This helps understanding the code at the call site without having to
look up the name of the argument or the default value.

This is a backport of core#19090 [5/6]
https://github.com/bitcoin/bitcoin/pull/19090/commits/fac43f9889f500bcb62d830c030dec42fe791031

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Aug 26 2021, 14:54

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 26 2021, 14:54

PiRK requested review of this revision.Aug 26 2021, 14:54

PiRK edited the summary of this revision. (Show Details)Aug 26 2021, 14:55

teamcity edited the summary of this revision. (Show Details)Aug 26 2021, 14:56

Harbormaster completed remote builds in B16438: Diff 29598.Aug 26 2021, 15:17

majcosta accepted this revision.Aug 26 2021, 17:57

This revision is now accepted and ready to land.Aug 26 2021, 17:57

Closed by commit rABC4526add5399a: scheduler: Replace stop(true) with StopWhenDrained() (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyAug 27 2021, 07:57

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC4526add5399a: scheduler: Replace stop(true) with StopWhenDrained().

Revision Contents
Changeset List

Path

Size

src/

avalanche/

test/

processor_tests.cpp

4 lines

scheduler.h

21 lines

scheduler.cpp

12 lines

test/

scheduler_tests.cpp

8 lines

Diff 29607

View Options

src/avalanche/test/processor_tests.cpp

View Options

src/scheduler.h

View Options

src/scheduler.cpp

View Options

src/test/scheduler_tests.cpp

scheduler: Replace stop(true) with StopWhenDrained()ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 29607

src/avalanche/test/processor_tests.cpp

src/scheduler.h

src/scheduler.cpp

src/test/scheduler_tests.cpp

scheduler: Replace stop(true) with StopWhenDrained()
ClosedPublic
Actions

Revision Contents
Changeset List