Page MenuHomePhabricator
Differential D9963

trivial: Suggested cleanups to surrounding code
ClosedPublic
Actions

Authored by PiRK on Aug 27 2021, 10:23.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABCbaf58a5d75fc: trivial: Suggested cleanups to surrounding code
Summary

https://github.com/bitcoin/bitcoin/pull/18982#pullrequestreview-416974841

This is a backport of core#18982 [2/2]
https://github.com/bitcoin/bitcoin/pull/18982/commits/7eaf86d3bfc83f2beb3ef449707d5156853126fb

Depends on D9962

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Aug 27 2021, 10:23
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 27 2021, 10:23
PiRK requested review of this revision.Aug 27 2021, 10:23
teamcity edited the summary of this revision. (Show Details)Aug 27 2021, 10:23
Harbormaster completed remote builds in B16442: Diff 29611.Aug 27 2021, 10:43
PiRK edited the summary of this revision. (Show Details)Aug 27 2021, 18:22
majcosta accepted this revision.Aug 27 2021, 20:43
majcosta added a subscriber: majcosta.
majcosta added inline comments.
src/wallet/wallet.cpp
1254 ↗(On Diff #29611)
1878 ↗(On Diff #29611)

same as above

This revision is now accepted and ready to land.Aug 27 2021, 20:43
PiRK planned changes to this revision.Aug 30 2021, 07:28

Standby while I assess if D9962 should be backported at all

PiRK requested review of this revision.Aug 30 2021, 14:16
This revision is now accepted and ready to land.Aug 30 2021, 14:16
PiRK updated this revision to Diff 29648.Aug 30 2021, 14:19

address feedback

Harbormaster completed remote builds in B16466: Diff 29648.Aug 30 2021, 14:33
Closed by commit rABCbaf58a5d75fc: trivial: Suggested cleanups to surrounding code (authored by Russell Yanofsky <russ@yanofsky.org>, committed by PiRK). · Explain WhyAug 30 2021, 16:35
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCbaf58a5d75fc: trivial: Suggested cleanups to surrounding code.

Revision Contents
Changeset List

PathSize
src/
4 lines
16 lines
wallet/
2 lines
34 lines

Diff 29658

View Options

src/validationinterface.h

Loading...
View Options

src/validationinterface.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...