Page MenuHomePhabricator
Differential D9969

walletdb: Handle cursor internally
ClosedPublic
Actions

Authored by PiRK on Aug 27 2021, 15:02.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABCd0c7f1c3fd6b: walletdb: Handle cursor internally
Summary

Instead of returning a Dbc (BDB cursor object) and having the caller
deal with the cursor, make BerkeleyBatch handle the cursor internally.

This prepares BerkeleyBatch to work with other database systems as Dbc
objects are BDB specific.

This is a backport of core#19308

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Aug 27 2021, 15:02
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 27 2021, 15:02
PiRK requested review of this revision.Aug 27 2021, 15:02
teamcity edited the summary of this revision. (Show Details)Aug 27 2021, 15:02
Harbormaster completed remote builds in B16448: Diff 29617.Aug 27 2021, 15:16
majcosta requested changes to this revision.Aug 27 2021, 21:05
majcosta added a subscriber: majcosta.
majcosta added inline comments.
src/wallet/bdb.cpp
563 ↗(On Diff #29617)
This revision now requires changes to proceed.Aug 27 2021, 21:05
PiRK updated this revision to Diff 29621.Aug 28 2021, 06:36

fix if condition

Harbormaster completed remote builds in B16452: Diff 29621.Aug 28 2021, 06:52
majcosta accepted this revision.Aug 28 2021, 08:22
This revision is now accepted and ready to land.Aug 28 2021, 08:22
Closed by commit rABCd0c7f1c3fd6b: walletdb: Handle cursor internally (authored by Andrew Chow <achow101-github@achow101.com>, committed by PiRK). · Explain WhyAug 30 2021, 06:31
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCd0c7f1c3fd6b: walletdb: Handle cursor internally.

Revision Contents
Changeset List

PathSize
src/
wallet/
6 lines
57 lines
27 lines

Diff 29629

View Options

src/wallet/bdb.h

Loading...
View Options

src/wallet/bdb.cpp

Loading...
View Options

src/wallet/walletdb.cpp

Loading...