Page MenuHomePhabricator

refactor: Remove confusing OutputType::CHANGE_AUTO

Authored by PiRK on Aug 30 2021, 11:10.

Diff Detail

rABC Bitcoin ABC
Lint Not Applicable
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Aug 30 2021, 11:10
majcosta requested changes to this revision.Aug 30 2021, 11:42
majcosta added a subscriber: majcosta.

make the changes to BIP70 related code in its own diff, so the backport is just the backport

This revision now requires changes to proceed.Aug 30 2021, 11:42

This is a backport of core#19336

this part of the summary needs fixing too

PiRK edited the summary of this revision. (Show Details)
PiRK edited the summary of this revision. (Show Details)

rebase onto D9976, to do the paymentserver.cpp in a separate diff

remove hard setting of m_default_change_type in wallet.cpp, which defeats the purpose of using a std::optional.

Remove the part of the comment that mentions -changetype option, which does not exist in Bitcoin ABC.

This revision is now accepted and ready to land.Aug 30 2021, 12:45