Page MenuHomePhabricator
Differential D9974

refactor: Remove confusing OutputType::CHANGE_AUTO
ClosedPublic
Actions

Authored by PiRK on Aug 30 2021, 11:10.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABCa33b200ef621: refactor: Remove confusing OutputType::CHANGE_AUTO
Summary

interfaces: Remove unused getDefaultChangeType

https://github.com/bitcoin/bitcoin/pull/19396/commits/fa2eb383522249a5f4d48726c520cec5de496614

Remove confusing OutputType::CHANGE_AUTO

https://github.com/bitcoin/bitcoin/pull/19396/commits/faddad71f648ed99734f4f8811bd4bc7232ca670

Enable Wswitch for OutputType

https://github.com/bitcoin/bitcoin/pull/19396/commits/fa927ff884ae373c676deed63180a8d238872cdc

This is a backport of core#19396

Test Plan

ninja all check-all

Diff Detail

Event Timeline

PiRK created this revision.Aug 30 2021, 11:10
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 30 2021, 11:10
PiRK requested review of this revision.Aug 30 2021, 11:10
teamcity edited the summary of this revision. (Show Details)Aug 30 2021, 11:10
Harbormaster completed remote builds in B16459: Diff 29636.Aug 30 2021, 11:24
majcosta requested changes to this revision.Aug 30 2021, 11:42
majcosta added a subscriber: majcosta.

make the changes to BIP70 related code in its own diff, so the backport is just the backport

This revision now requires changes to proceed.Aug 30 2021, 11:42
majcosta added a comment.Aug 30 2021, 11:46

This is a backport of core#19336

this part of the summary needs fixing too

PiRK edited the summary of this revision. (Show Details)Aug 30 2021, 11:58
PiRK edited the summary of this revision. (Show Details)
PiRK edited the summary of this revision. (Show Details)Aug 30 2021, 12:07
PiRK mentioned this in D9976: remove use of getDefaultChangeType in paymentserver.cpp.Aug 30 2021, 12:07
PiRK updated this revision to Diff 29642.Aug 30 2021, 12:09
PiRK edited the summary of this revision. (Show Details)

rebase onto D9976, to do the paymentserver.cpp in a separate diff

PiRK updated this revision to Diff 29643.Aug 30 2021, 12:19

remove hard setting of m_default_change_type in wallet.cpp, which defeats the purpose of using a std::optional.

Remove the part of the comment that mentions -changetype option, which does not exist in Bitcoin ABC.

Harbormaster completed remote builds in B16462: Diff 29642.Aug 30 2021, 12:37
Harbormaster completed remote builds in B16463: Diff 29643.Aug 30 2021, 12:44
majcosta accepted this revision.Aug 30 2021, 12:45
This revision is now accepted and ready to land.Aug 30 2021, 12:45
Closed by commit rABCa33b200ef621: refactor: Remove confusing OutputType::CHANGE_AUTO (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyAug 30 2021, 13:15
This revision was automatically updated to reflect the committed changes.
PiRK mentioned this in rABC1c09834d5f06: remove use of getDefaultChangeType in paymentserver.cpp.
PiRK added a commit: rABCa33b200ef621: refactor: Remove confusing OutputType::CHANGE_AUTO.

Revision Contents
Changeset List

PathSize
src/
interfaces/
3 lines
3 lines
10 lines
15 lines
wallet/
6 lines
5 lines
16 lines
8 lines

Diff 29642

View Options

src/interfaces/wallet.h

Loading...
View Options

src/interfaces/wallet.cpp

Loading...
View Options

src/outputtype.h

Loading...
View Options

src/outputtype.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/scriptpubkeyman.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...