avalanche: method to get std::vector<avalanche::Node> associated with a PeerId
AbandonedPublic
Actions

Authored by majcosta on Aug 30 2021, 11:38.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Summary

as title

Test Plan

ninja check-avalanche-peermanager_tests

Diff Detail

Repository

rABC Bitcoin ABC

Branch

get_nodes_belonging_to_a_peer

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16460
Build 32783: Build Diff	build-debug · build-without-wallet · build-clang-tidy · build-clang · lint-circular-dependencies · build-diff
Build 32782: arc lint + arc unit

Event Timeline

majcosta created this revision.Aug 30 2021, 11:38

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 30 2021, 11:38

majcosta requested review of this revision.Aug 30 2021, 11:38

Harbormaster completed remote builds in B16460: Diff 29637.Aug 30 2021, 11:52

What is the use case for this ? And isn't possible to achieve what you want with the existing forEachNode() that won't make a copy of each node ?

src/avalanche/peermanager.h
238	`Proof broadcast API.` is not the right section for this

This revision now requires changes to proceed.Aug 30 2021, 11:56

the point of this is when a p2p node asks another for which nodes he has for a given proof

addressed feedback about avoiding copies of avalanche:Node objects (NodeId is what we care about, really) and moved the method declaration to a more appropriate line

Harbormaster completed remote builds in B16464: Diff 29644.Aug 30 2021, 13:02

majcosta planned changes to this revision.Aug 30 2021, 19:40

majcosta abandoned this revision.Sep 7 2022, 18:31