Page MenuHomePhabricator

[Cashtab] Standard component for API error msg
ClosedPublic

Authored by bytesofman on Aug 30 2021, 19:01.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC64fe2ca3e453: [Cashtab] Standard component for API error msg
Summary

T1769

Cashtab API errors were added incrementally in line with other features. The component appears in several screens and should be standardized.

This diff makes the error msg a standard component.

Test Plan

Edit line 227 of useWallet.js from setApiError(false) to setApiError(true)
npm start
Observe the API error msg on home screen, send screen, settings screen, tokens screen, and send tokens screens; confirm placement and style are ok

Diff Detail

Repository
rABC Bitcoin ABC
Branch
api-error-to-component
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16473
Build 32809: Build Diffcashtab-tests
Build 32808: arc lint + arc unit

Event Timeline

Fabien added a subscriber: Fabien.

OK for that diff, but please make the positioning consistent across the pages in another diff. They all look the same which is great but seems to be located randomly over pages.

web/cashtab/src/components/Common/ApiError.js
10

nit: can be self-closing <br />

This revision is now accepted and ready to land.Aug 31 2021, 06:41