Differential D9990

Revert "test: Show debug log on unit test failure"
ClosedPublic
Actions

Authored by PiRK on Aug 31 2021, 08:39.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC831c8d793a79: Revert "test: Show debug log on unit test failure"

Summary

This reverts rABCee4e128c034d2ce2a50bf4df4e90b49b5709dfbe.

This cause segmentation faults. The fixture triggers a double free.

Test Plan

@Fabien was able to consistently reproduce the issue with ASAN and bisected it to this commit.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Aug 31 2021, 08:39

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 31 2021, 08:39

PiRK requested review of this revision.Aug 31 2021, 08:39

Fabien accepted this revision.Aug 31 2021, 08:50

Fabien edited the summary of this revision. (Show Details)

This revision is now accepted and ready to land.Aug 31 2021, 08:51

Harbormaster completed remote builds in B16481: Diff 29672.Aug 31 2021, 08:56

Closed by commit rABC831c8d793a79: Revert "test: Show debug log on unit test failure" (authored by PiRK). · Explain WhyAug 31 2021, 09:16

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC831c8d793a79: Revert "test: Show debug log on unit test failure".

PiRK mentioned this in D9983: wallet: Replace CDataStream& with CDataStream&& where appropriate.Aug 31 2021, 09:19

PiRK mentioned this in D9985: qt: Reset toolbar after all wallets are closed.Aug 31 2021, 11:17

PiRK mentioned this in D9834: test: Set -logthreadnames in unit tests.Jan 20 2022, 11:37

Revision Contents
Changeset List

Path

Size

src/

avalanche/

test/

fixture.cpp

13 lines

bench/

bench.cpp

2 lines

pow/

test/

fixture.cpp

13 lines

qt/

test/

test_main.cpp

2 lines

seeder/

test/

fixture.cpp

13 lines

test/

fixture.cpp

15 lines

fuzz/

fuzz.cpp

5 lines

util/

setup_common.h

4 lines

setup_common.cpp

3 lines

test/

sanitizer_suppressions/

tsan

8 lines

Diff 29674

View Options

src/avalanche/test/fixture.cpp

View Options

src/bench/bench.cpp

View Options

src/pow/test/fixture.cpp

View Options

src/qt/test/test_main.cpp

View Options

src/seeder/test/fixture.cpp

View Options

src/test/fixture.cpp

View Options

src/test/fuzz/fuzz.cpp

View Options

src/test/util/setup_common.h

View Options

src/test/util/setup_common.cpp

View Options

test/sanitizer_suppressions/tsan

Revert "test: Show debug log on unit test failure"ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 29674

src/avalanche/test/fixture.cpp

src/bench/bench.cpp

src/pow/test/fixture.cpp

src/qt/test/test_main.cpp

src/seeder/test/fixture.cpp

src/test/fixture.cpp

src/test/fuzz/fuzz.cpp

src/test/util/setup_common.h

src/test/util/setup_common.cpp

test/sanitizer_suppressions/tsan

Revert "test: Show debug log on unit test failure"
ClosedPublic
Actions

Revision Contents
Changeset List