Diffusion Bitcoin ABC 831c8d793a79

Revert "test: Show debug log on unit test failure"
831c8d793a79
Actions

Description

Revert "test: Show debug log on unit test failure"

Summary:
This reverts rABCee4e128c034d2ce2a50bf4df4e90b49b5709dfbe.

This cause segmentation faults. The fixture triggers a double free.

Test Plan: @Fabien was able to consistently reproduce the issue with ASAN and bisected it to this commit.

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D9990

Details

Provenance

PiRK	Authored on Aug 31 2021, 08:36
PiRK	Pushed on Aug 31 2021, 09:16

Reviewer

Restricted Project

Differential Revision

D9990: Revert "test: Show debug log on unit test failure"

Parents

rABCc501ed2fa6da: test: Test gettxouttsetinfo hash_type option

Branches

Unknown

Tags

Unknown

Reverts

D9971: test: Show debug log on unit test failure
rABCee4e128c034d: test: Show debug log on unit test failure

Event Timeline

PiRK committed rABC831c8d793a79: Revert "test: Show debug log on unit test failure" (authored by PiRK).Aug 31 2021, 09:16

PiRK added reverted changes: rABCee4e128c034d: test: Show debug log on unit test failure, D9971: test: Show debug log on unit test failure.

PiRK added an edge: D9990: Revert "test: Show debug log on unit test failure".

PiRK added a subscriber: Fabien.

teamcity mentioned this in T1809: Build Bitcoin-ABC / CashTab / CashTab Unit Tests is broken..Aug 31 2021, 09:32

Changes (10)

Path

Size

src/

	avalanche/	test/
	networks/	abc/

	fixture.cpp
	network.cpp

bench/

bench.cpp

	pow/	test/
	networks/	abc/

	fixture.cpp
	network.cpp

qt/

test/

test_main.cpp

	seeder/	test/
	networks/	abc/

	fixture.cpp
	network.cpp

test/

fuzz/

util/

test/

sanitizer_suppressions/

tsan

rABC831c8d793a79

View Options

src/avalanche/test/fixture.cpp

View Options

src/bench/bench.cpp

View Options

src/pow/test/fixture.cpp

View Options

src/qt/test/test_main.cpp

View Options

src/seeder/test/fixture.cpp

View Options

src/test/fixture.cpp

View Options

src/test/fuzz/fuzz.cpp

View Options

src/test/util/setup_common.cpp

View Options

src/test/util/setup_common.h

View Options

test/sanitizer_suppressions/tsan

Revert "test: Show debug log on unit test failure"831c8d793a79Actions

Description

Details

Event Timeline

Changes (10)

rABC831c8d793a79

src/avalanche/test/fixture.cpp

src/bench/bench.cpp

src/pow/test/fixture.cpp

src/qt/test/test_main.cpp

src/seeder/test/fixture.cpp

src/test/fixture.cpp

src/test/fuzz/fuzz.cpp

src/test/util/setup_common.cpp

src/test/util/setup_common.h

test/sanitizer_suppressions/tsan

Revert "test: Show debug log on unit test failure"
831c8d793a79
Actions