Page MenuHomePhabricator
Differential D9971

test: Show debug log on unit test failure
ClosedPublic
Actions

Authored by PiRK on Aug 27 2021, 15:59.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABCee4e128c034d: test: Show debug log on unit test failure
Summary

This is a backport of core#16975

Test Plan

ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Aug 27 2021, 15:59
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 27 2021, 15:59
PiRK requested review of this revision.Aug 27 2021, 15:59
teamcity edited the summary of this revision. (Show Details)Aug 27 2021, 15:59
PiRK added a comment.Aug 27 2021, 16:03

i think this should be tested by others, and discussed. The result adds a lot of verbosity, and usually unit test failures are already quite verbose (because of the long loops).

I tried it with the following patch:

diff --git a/src/avalanche/test/processor_tests.cpp b/src/avalanche/test/processor_tests.cpp
index 240522d2c7..5d3d895cf6 100644
--- a/src/avalanche/test/processor_tests.cpp
+++ b/src/avalanche/test/processor_tests.cpp
@@ -336,6 +336,7 @@ BOOST_AUTO_TEST_CASE(block_register) {
     BOOST_CHECK_EQUAL(invs.size(), 1);
     BOOST_CHECK_EQUAL(invs[0].type, MSG_BLOCK);
     BOOST_CHECK(invs[0].hash == blockHash);
+    BOOST_CHECK(false);

     // Newly added blocks' state reflect the blockchain.
     BOOST_CHECK(m_processor->isAccepted(pindex));
Harbormaster completed remote builds in B16450: Diff 29619.Aug 27 2021, 16:12
majcosta requested changes to this revision.Aug 27 2021, 21:15
majcosta added a subscriber: majcosta.
majcosta added inline comments.
src/avalanche/test/fixture.cpp
20 ↗(On Diff #29619)

add newline

src/pow/test/fixture.cpp
20 ↗(On Diff #29619)

ditto

This revision now requires changes to proceed.Aug 27 2021, 21:15
PiRK updated this revision to Diff 29622.Aug 28 2021, 06:39

add newlines at EOF

Harbormaster completed remote builds in B16453: Diff 29622.Aug 28 2021, 07:18
majcosta accepted this revision.Aug 28 2021, 08:22
This revision is now accepted and ready to land.Aug 28 2021, 08:22
Closed by commit rABCee4e128c034d: test: Show debug log on unit test failure (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyAug 31 2021, 06:30
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCee4e128c034d: test: Show debug log on unit test failure.
PiRK added a reverting change: D9990: Revert "test: Show debug log on unit test failure".Aug 31 2021, 08:39
PiRK added a reverting change: rABC831c8d793a79: Revert "test: Show debug log on unit test failure".Aug 31 2021, 09:16
PiRK mentioned this in D9834: test: Set -logthreadnames in unit tests.Jan 20 2022, 11:37

Revision Contents
Changeset List

PathSize
src/
avalanche/
test/
13 lines
bench/
2 lines
pow/
test/
13 lines
qt/
test/
2 lines
seeder/
test/
13 lines
test/
15 lines
fuzz/
5 lines
util/
4 lines
3 lines
test/
sanitizer_suppressions/
8 lines

Diff 29660

View Options

src/avalanche/test/fixture.cpp

Loading...
View Options

src/bench/bench.cpp

Loading...
View Options

src/pow/test/fixture.cpp

Loading...
View Options

src/qt/test/test_main.cpp

Loading...
View Options

src/seeder/test/fixture.cpp

Loading...
View Options

src/test/fixture.cpp

Loading...
View Options

src/test/fuzz/fuzz.cpp

Loading...
View Options

src/test/util/setup_common.h

Loading...
View Options

src/test/util/setup_common.cpp

Loading...
View Options

test/sanitizer_suppressions/tsan

Loading...