Backport Core PR 10169: [tests] remove func test code duplication
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	schancel
	Dec 19 2017, 21:48

Description

Port over the following two commits from core.

commit 8f3e38477e30abd9dd0e24a4d612126117f7793c
Merge: 2580ff81f 2a52ae63b
Author: Wladimir J. van der Laan <laanwj@gmail.com>
Date:   Tue May 2 19:10:23 2017 +0200

    Merge #10169: [tests] Remove func test code duplication

    2a52ae6 Remove duplicate method definitions in NodeConnCB subclasses (John Newbery)
    52e15aa Adds helper functions to NodeConnCB (John Newbery)

    Tree-SHA512: 2d7909eb85b3bde0fc3ebf133798eca21e561f4b2a2880937750820a42856cfb61fc94e30591c14ac13218bcfae0ebe7c5e8662a7b10f5b02470325c44a86cf1

Related Objects
Search...

		Status	Assigned	Task
		Open	None	T126 Backports from Bitcoin Core
		Resolved	matiu	T147 Backport Core PR 10169: [tests] remove func test code duplication

Event Timeline

schancel created this task.Dec 19 2017, 21:48

schancel added a parent task: T126: Backports from Bitcoin Core.Jan 17 2018, 23:57

schancel renamed this task from Improve NodeConnDB to Backport Core PR 10169: [tests] remove func test code duplication.Jan 20 2018, 20:05

schancel updated the task description. (Show Details)

This one seems applied to:

https://github.com/bitcoin/bitcoin/pull/10169/files
vs, for example:
https://reviews.bitcoinabc.org/source/bitcoin-abc/browse/master/test/functional/maxuploadtarget.py;0961aae4722018e7396828b5d9455c927fc6ec42$35

Backport Core PR 10169: [tests] remove func test code duplicationClosed, ResolvedPublicActions

Description

Related ObjectsSearch...

Event Timeline

Backport Core PR 10169: [tests] remove func test code duplication
Closed, ResolvedPublic
Actions

Related Objects
Search...