Page MenuHomePhabricator
Differential D2736 Diff 7825 test/functional/test_framework/test_framework.py

Changeset View

Standalone View

View Options

test/functional/test_framework/test_framework.py

#!/usr/bin/env python3 #!/usr/bin/env python3
Lint: Code style violation
Inline Actions

'/home/nico/bitcoin-abc/test/functional/test_framework/test_framework.py' has code style errors.

Lint: Code style violation: '/home/nico/bitcoin-abc/test/functional/test_framework/test_framework.py' has code style errors.
nakihitoAuthorUnsubmitted
Done
Inline Actions

There are numerous linter errors outside of the scope of this backport. See history for the potential linter changes.

nakihito: There are numerous linter errors outside of the scope of this backport. See history for the…
FabienUnsubmitted
Not Done
Inline Actions

@nakihito I'm interested in knowing your autopep8 version, your python linter seems more aggressive than mine.
Also can you check if you have some configuration file which may enable more aggressive linting ?

For example I have zero error with arc lint -- test/functional/test_framework/test_framework.py.

Fabien: @nakihito I'm interested in knowing your autopep8 version, your python linter seems more…
nakihitoAuthorUnsubmitted
Done
Inline Actions

I have autopep8 version 0.9.1. I never touched the linter's config file. I can copy-paste it if you would like.

nakihito: I have autopep8 version 0.9.1. I never touched the linter's config file. I can copy-paste it…
FabienUnsubmitted
Not Done
Inline Actions

Thanks, your version is far behind mine and @jasonbcox's.
I will enforce a minimum version, you'll need to update.

Fabien: Thanks, your version is far behind mine and @jasonbcox's. I will enforce a minimum version…
# Copyright (c) 2014-2016 The Bitcoin Core developers # Copyright (c) 2014-2016 The Bitcoin Core developers
# Distributed under the MIT software license, see the accompanying # Distributed under the MIT software license, see the accompanying
# file COPYING or http://www.opensource.org/licenses/mit-license.php. # file COPYING or http://www.opensource.org/licenses/mit-license.php.
"""Base class for RPC testing.""" """Base class for RPC testing."""
import argparse import argparse
from collections import deque from collections import deque
from enum import Enum from enum import Enum
▲ Show 20 Lines • Show All 145 Lines • ▼ Show 20 Lines def main(self):
print("Testcase failed. Attaching python debugger. Enter ? for help") print("Testcase failed. Attaching python debugger. Enter ? for help")
pdb.set_trace() pdb.set_trace()
if not self.options.noshutdown: if not self.options.noshutdown:
self.log.info("Stopping nodes") self.log.info("Stopping nodes")
if self.nodes: if self.nodes:
self.stop_nodes() self.stop_nodes()
else: else:
for node in self.nodes:
node.cleanup_on_exit = False
self.log.info( self.log.info(
"Note: bitcoinds were not stopped and may still be running") "Note: bitcoinds were not stopped and may still be running")
if not self.options.nocleanup and not self.options.noshutdown and success != TestStatus.FAILED: if not self.options.nocleanup and not self.options.noshutdown and success != TestStatus.FAILED:
self.log.info("Cleaning up") self.log.info("Cleaning up")
shutil.rmtree(self.options.tmpdir) shutil.rmtree(self.options.tmpdir)
else: else:
self.log.warning( self.log.warning(
▲ Show 20 Lines • Show All 349 Lines • Show Last 20 Lines