[qa] Ensure bitcoind processes are cleaned up when tests end
AbandonedPublic
Actions

Authored by nakihito on Mar 25 2019, 21:41.

Details

Reviewers

jasonbcox
deadalnix
Fabien

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Summary

[qa] Ensure bitcoind processes are cleaned up when tests end
Backport of PR12904
https://github.com/bitcoin/bitcoin/pull/12904/files

Completes T446

Test Plan

make check
test_runner.py
Interrupting (though keyboard for example) test_runner.py should not leave any zombie bitcoind instances running (checked with top)

Diff Detail

Repository

rABC Bitcoin ABC

Branch

BackportPR12904

Lint

Lint Passed

Severity	Location	Code	Message
Auto-Fix	test/functional/test_framework/test_framework.py:1	CFMT	Code style violation
Auto-Fix	test/functional/test_framework/test_node.py:1	CFMT	Code style violation

Unit

No Test Coverage

Build Status

Buildable 5306
Build 8674: Bitcoin ABC Buildbot (legacy)
Build 8673: arc lint + arc unit

Event Timeline

nakihito created this revision.Mar 25 2019, 21:41

Owners added a reviewer: Restricted Owners Package.Mar 25 2019, 21:41

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 25 2019, 21:41

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

nakihito edited the summary of this revision. (Show Details)Mar 25 2019, 21:42

Fixed unwanted linter changes.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

nakihito added inline comments.Mar 25 2019, 21:53

test/functional/test_framework/test_framework.py
1 ↗	(On Diff #7825)	There are numerous linter errors outside of the scope of this backport. See history for the potential linter changes.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5295: Diff 7824.Mar 25 2019, 21:56

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5296: Diff 7825.Mar 25 2019, 22:05

This PR depends on PR12843 (T569) for the feature_help.py script.
This one in turns has dependencies which require T417 to be completed first (see T540, T568).

test/functional/test_framework/test_framework.py
1 ↗	(On Diff #7825)	@nakihito I'm interested in knowing your autopep8 version, your python linter seems more aggressive than mine. Also can you check if you have some configuration file which may enable more aggressive linting ? For example I have zero error with `arc lint -- test/functional/test_framework/test_framework.py`.
test/functional/test_framework/test_node.py
90 ↗	(On Diff #7825)	Move comment above

This revision now requires changes to proceed.Mar 26 2019, 08:59

Change comment position in test_node.py.

test/functional/test_framework/test_framework.py
1 ↗	(On Diff #7825)	I have autopep8 version 0.9.1. I never touched the linter's config file. I can copy-paste it if you would like.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5306: Diff 7836.Mar 26 2019, 20:01

This diff should be updated after the dependencies are backported, I request change to clear my queue.
Please update and request review again when the missing file is added.