Page MenuHomePhabricator

[qa] Ensure bitcoind processes are cleaned up when tests end
Needs RevisionPublic

Authored by nakihito on Mar 25 2019, 21:41.

Details

Reviewers
jasonbcox
deadalnix
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

[qa] Ensure bitcoind processes are cleaned up when tests end
Backport of PR12904
https://github.com/bitcoin/bitcoin/pull/12904/files

Completes T446

Test Plan

make check
test_runner.py
Interrupting (though keyboard for example) test_runner.py should not leave any zombie bitcoind instances running (checked with top)

Diff Detail

Repository
rABC Bitcoin ABC
Branch
BackportPR12904
Lint
Lint OK
SeverityLocationCodeMessage
Auto-Fixtest/functional/test_framework/test_framework.py:1CFMTCode style violation
Auto-Fixtest/functional/test_framework/test_node.py:1CFMTCode style violation
Unit
No Unit Test Coverage
Build Status
Buildable 5306
Build 8674: Bitcoin ABC Teamcity Staging
Build 8673: arc lint + arc unit

Event Timeline

nakihito created this revision.Mar 25 2019, 21:41
Owners added a reviewer: Restricted Owners Package.Mar 25 2019, 21:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 25 2019, 21:41
Herald added a subscriber: schancel. · View Herald Transcript
nakihito edited the summary of this revision. (Show Details)Mar 25 2019, 21:42
nakihito updated this revision to Diff 7825.Mar 25 2019, 21:50

Fixed unwanted linter changes.

nakihito added inline comments.Mar 25 2019, 21:53
test/functional/test_framework/test_framework.py
1 ↗(On Diff #7825)

There are numerous linter errors outside of the scope of this backport. See history for the potential linter changes.

Fabien requested changes to this revision.Tue, Mar 26, 08:59

This PR depends on PR12843 (T569) for the feature_help.py script.
This one in turns has dependencies which require T417 to be completed first (see T540, T568).

test/functional/test_framework/test_framework.py
1 ↗(On Diff #7825)

@nakihito I'm interested in knowing your autopep8 version, your python linter seems more aggressive than mine.
Also can you check if you have some configuration file which may enable more aggressive linting ?

For example I have zero error with arc lint -- test/functional/test_framework/test_framework.py.

test/functional/test_framework/test_node.py
90 ↗(On Diff #7825)

Move comment above

This revision now requires changes to proceed.Tue, Mar 26, 08:59
nakihito updated this revision to Diff 7836.Tue, Mar 26, 19:45
nakihito marked an inline comment as done.

Change comment position in test_node.py.

test/functional/test_framework/test_framework.py
1 ↗(On Diff #7825)

I have autopep8 version 0.9.1. I never touched the linter's config file. I can copy-paste it if you would like.

Fabien requested changes to this revision.Thu, Mar 28, 08:39

This diff should be updated after the dependencies are backported, I request change to clear my queue.
Please update and request review again when the missing file is added.

test/functional/test_framework/test_framework.py
1 ↗(On Diff #7825)

Thanks, your version is far behind mine and @jasonbcox's.
I will enforce a minimum version, you'll need to update.

This revision now requires changes to proceed.Thu, Mar 28, 08:39