Page MenuHomePhabricator
Differential D3235

Merge #12904: [qa] Ensure bitcoind processes are cleaned up when tests end
ClosedPublic
Actions

Authored by nakihito on Jun 6 2019, 18:21.

Details

Reviewers
jasonbcox
deadalnix
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGf5873a89b694: Merge #12904: [qa] Ensure bitcoind processes are cleaned up when tests end
rABCf5873a89b694: Merge #12904: [qa] Ensure bitcoind processes are cleaned up when tests end
Summary

e36a0c0 [qa] Ensure bitcoind processes are cleaned up when tests end (Suhas Daftuar)

Pull request description:

When tests fail (such as due to a bug in the test, race condition, etc), it's possible that we could follow code paths that bypass our normal node shutdown that occurs in `TestNode.stop_node`.  Add a destructor to `TestNode` that cleans this up.

Tree-SHA512: 72e04bc21462ebd0cb346fd1fe0540da454acfbad41923a0b06ea2317e9045b68e58f9adb02d8200891aca89a9d03a022eb72282aeb31a3b3afe7c6843a4b450

Backport of Core PR12904
https://github.com/bitcoin/bitcoin/pull/12904/

Depends on D3234

Completes T446

Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Jun 6 2019, 18:21
Owners added a reviewer: Restricted Owners Package.Jun 6 2019, 18:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 6 2019, 18:21
teamcity added a comment.Jun 6 2019, 18:21

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

nakihito mentioned this in D2736: [qa] Ensure bitcoind processes are cleaned up when tests end.Jun 6 2019, 18:21
teamcity added a comment.Jun 6 2019, 18:31

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6185: Diff 9194.Jun 6 2019, 18:31
jasonbcox requested changes to this revision.Jun 6 2019, 18:35
jasonbcox added inline comments.
test/functional/test_framework/test_node.py
99 ↗(On Diff #9194)

Move comment on line above this one

This revision now requires changes to proceed.Jun 6 2019, 18:35
nakihito updated this revision to Diff 9208.Jun 6 2019, 21:05

Rebased and fixed comment placement.

teamcity added a comment.Jun 6 2019, 21:05

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 6 2019, 21:16

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6190: Diff 9208.Jun 6 2019, 21:16
deadalnix accepted this revision.Jun 6 2019, 22:39
jasonbcox accepted this revision.Jun 6 2019, 23:11
This revision is now accepted and ready to land.Jun 6 2019, 23:11
Closed by commit rABCf5873a89b694: Merge #12904: [qa] Ensure bitcoind processes are cleaned up when tests end (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhyJun 6 2019, 23:17
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABCf5873a89b694: Merge #12904: [qa] Ensure bitcoind processes are cleaned up when tests end.
Nico Guiton <nico@bitframe.org> added a commit: rSTAGINGf5873a89b694: Merge #12904: [qa] Ensure bitcoind processes are cleaned up when tests end.Sep 19 2019, 00:08

Revision Contents
Changeset List

PathSize
test/
functional/
4 lines
test_framework/
2 lines
13 lines

Diff 9223

View Options

test/functional/feature_help.py

Loading...
View Options

test/functional/test_framework/test_framework.py

Loading...
View Options

test/functional/test_framework/test_node.py

Loading...