Page MenuHomePhabricator

Merge #12904: [qa] Ensure bitcoind processes are cleaned up when tests end
ClosedPublic

Authored by nakihito on Thu, Jun 6, 18:21.

Details

Reviewers
jasonbcox
deadalnix
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABCf5873a89b694: Merge #12904: [qa] Ensure bitcoind processes are cleaned up when tests end
Summary

e36a0c0 [qa] Ensure bitcoind processes are cleaned up when tests end (Suhas Daftuar)

Pull request description:

When tests fail (such as due to a bug in the test, race condition, etc), it's possible that we could follow code paths that bypass our normal node shutdown that occurs in `TestNode.stop_node`.  Add a destructor to `TestNode` that cleans this up.

Tree-SHA512: 72e04bc21462ebd0cb346fd1fe0540da454acfbad41923a0b06ea2317e9045b68e58f9adb02d8200891aca89a9d03a022eb72282aeb31a3b3afe7c6843a4b450

Backport of Core PR12904
https://github.com/bitcoin/bitcoin/pull/12904/

Depends on D3234

Completes T446

Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Thu, Jun 6, 18:21
Owners added a reviewer: Restricted Owners Package.Thu, Jun 6, 18:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Jun 6, 18:21
jasonbcox requested changes to this revision.Thu, Jun 6, 18:35
jasonbcox added inline comments.
test/functional/test_framework/test_node.py
99 ↗(On Diff #9194)

Move comment on line above this one

This revision now requires changes to proceed.Thu, Jun 6, 18:35
nakihito updated this revision to Diff 9208.Thu, Jun 6, 21:05

Rebased and fixed comment placement.

deadalnix accepted this revision.Thu, Jun 6, 22:39
jasonbcox accepted this revision.Thu, Jun 6, 23:11
This revision is now accepted and ready to land.Thu, Jun 6, 23:11