Page MenuHomePhabricator
Create Task
Maniphest T417

Backport PR10244 from core
Closed, ResolvedPublic
Actions

Description

https://github.com/bitcoin/bitcoin/pull/10244/files

This PR improves the codebase quite a bit, but is also difficult to backport because it is a "shotgun" change. It can backported in several small pieces. When cherry picking one of the commits, conflict will happen. If the conflict are trivial, then they can be solved. If they are more complex, then it is usually due to some other change done in Bitcoin Core and that needs to be backported first.

Note: this change needs to include https://github.com/bitcoin/bitcoin/pull/12906/files as well. Best done merged before committing to prevent breaking the windows build (see discussion).

Related Objects
Search...

StatusAssignedTask
 ResolvednakihitoT601 Backport Core PR 10973: Refactor: separate wallet from node
 ResolvednakihitoT602 Backport Core PR 15288: Remove wallet -> node global function calls
 ResolvednakihitoT603 Backport Core PR 10976: Refactor: separate wallet from node
 ResolvednakihitoT600 Backport Core PR 14711: Refactor: Start to separate wallet from node
 ResolvedjasonbcoxT445 December backports
 ResolvedjasonbcoxT446 Backport Core PR 12904
 ResolvedFabienT569 Backport PR12843
 ResolvednakihitoT595 Backport Core PR15639: bitcoin-wallet tool: Drop libbitcoin_server.a dependency
 ResolvednakihitoT596 Backport Core PR 14350: Add WalletLocation class
 ResolvednakihitoT592 Backport Core PR 14437: Refactor: Start to separate wallet from node
 ResolvedjasonbcoxT623 Backport Core PR 13023
 ResolvedjasonbcoxT626 Backport Core PR 12988
 ResolvedjasonbcoxT537 Backport Core PR14670
 ResolvedmarkblundebergT648 Backport PR 12806 qa: Fix function names in feature_blocksdir
 ResolvednakihitoT581 Backport Core PR 14206
 ResolvedjasonbcoxT575 Backport Core PR 14532: reduce attack surface of RPC server
 ResolvednakihitoT582 Backport Core PR 13341
 ResolvedFabienT437 Backport core PR 11738
 ResolvedjasonbcoxT638 Backport Core PR 11738 (fix hang in sendrawtransaction)
 ResolveddeadalnixT436 Backport core PR 10286
 OpenNoneT650 Backport Core PR 13197 "util: warn about ignored recursive -includeconf calls"
 ResolvedjasonbcoxT540 Backport Core PR12755
 ResolvedjasonbcoxT447 Backport Core PR 12902
 ResolvedjasonbcoxT448 Backport Core PR 12220
 ResolvedjasonbcoxT449 Backport Core PR 11466
 ResolvedFabienT568 Backport PR12718 "[Tests] Require exact match in assert_start_raises_init_error"
 ResolvedFabienT652 Backport PR13126
 ResolvedjasonbcoxT541 Backport Core PR10267 to support includeconf
 ResolvedjasonbcoxT574 Backport Core PR 14708: unrecognized section names in the config should supply warnings in the logs
 ResolvednakihitoT591 Backport Core 14494: Error if # is used in rpcpassword in conf
 ResolvedjasonbcoxT590 Backport Core 14555: Move util files to new directory
 ResolveddeadalnixT637 Backport Core PR 14168: Remove ENABLE_WALLET from libbitcoin_server.a
 ResolvednakihitoT583 Backport Core PR 13190
 OpennakihitoT597 Backport Core PR 15357: rpc: Don't ignore `-maxtxfee` when wallet is disabled
ResolvedmajcostaT598 Backport Core PR 12909: wallet: Make fee settings to be non-static members
 ResolvedjasonbcoxT416 October backport session
 ResolvedjasonbcoxT558 Backport Core PR 12830
 ResolvedjasonbcoxT571 Backport Core PR 10973
 ResolvedjasonbcoxT417 Backport PR10244 from core
 ResolvedjasonbcoxT426 Backport PR10832
 ResolvedjasonbcoxT427 Backport PR9834
 ResolvedjasonbcoxT430 Backport Core PR 11698
 ResolvedjasonbcoxT431 Backport Core PR 10362
 ResolvedjasonbcoxT432 Backport Core PR 9500
 ResolvedjasonbcoxT440 Backport Core PR 12610 and friends for multiwallet support
 ResolvedjasonbcoxT442 Backport Core PR 11335
 ResolvedjasonbcoxT441 Backport Core PR 10870
 ResolvedjasonbcoxT443 Backport Core PR 11169
 ResolvedjasonbcoxT444 Backport Core PR 10093
 ResolvedjasonbcoxT318 Backport PR 11335 to fix window restore
 ResolvedjasonbcoxT507 Backport Core PR 12266
 ResolvedjasonbcoxT510 Backport Core PR 10231
 ResolvedFabienT511 Backport Core PR 10770
 ResolvedjasonbcoxT512 Backport Core PR 10420
 ResolvedjasonbcoxT513 Backport Core PR 11365
 InvalidjasonbcoxT514 Backport Core PR 9424
 WontfixjasonbcoxT515 Backport Core PR 10449
 ResolvedjasonbcoxT508 Backport Core PR 10839
 ResolvedjasonbcoxT509 Backport Core PR 10769
 ResolvedFabienT517 Backport Core PR 9680
 ResolvedjasonbcoxT518 Backport Core PR 12276
 ResolvedjasonbcoxT519 Backport Core PR 11132
 ResolvedjasonbcoxT520 Backport Core PR 10303
 ResolvedjasonbcoxT521 Backport Core PR 10706
 ResolvedjasonbcoxT522 Backport Core PR 10390
 ResolvedjasonbcoxT516 Backport Core PR 10295
 ResolvedjasonbcoxT523 Backport Core PR10165
 ResolvedjasonbcoxT534 Backport Core PR10712
 ResolvedjasonbcoxT535 Backport Core PR10294
 ResolvedjasonbcoxT546 Partial backport of Core PR9672
 ResolvedjasonbcoxT547 Partial backport of Core PR9681
 ResolvedFabienT543 Backport PR11623
 ResolvedFabienT544 Backport PR11824
 ResolvedjasonbcoxT548 Backport Core PR 11809
 ResolvedjasonbcoxT549 Backport Core PR 10742
 ResolvedNoneT570 Backport Core PR 11923
 ResolvedjasonbcoxT550 Backport Core PR 11039
 ResolvedjasonbcoxT551 Backport Core PR 9622
 ResolvedjasonbcoxT552 Backport Core PR 10783
 ResolvedjasonbcoxT556 Backport Core PR 12327
 ResolvednakihitoT557 Backport Core PR 11733
 ResolvednakihitoT559 Backport Core PR 10964
 ResolvedjasonbcoxT560 Backport Core PR 11041
 ResolvednakihitoT561 Backport Core PR 12083
 ResolvednakihitoT566 Backport Core PR12317
 ResolvedjasonbcoxT562 Backport Core PR 10275
 ResolvedjasonbcoxT564 Backport Core PR 11027
 ResolvednakihitoT565 Backport Core PR 11529
 ResolvedjasonbcoxT563 Backport Core PR 11565
 ResolvedjasonbcoxT572 Backport Core PR 10279
 ResolvedjasonbcoxT577 Backport Core PR 10493
 ResolvedjasonbcoxT462 Backport Core PR11367 for more info in getblockchaininfo output
 ResolvednakihitoT567 Backport Core PR10858
 ResolvedjasonbcoxT593 Backport Core PR 11838
 ResolvedjasonbcoxT588 Backport Core PR 10368
 ResolvednakihitoT599 Backport Core PR 3716: GUI: Receive: Remove option to reuse a previous address
 ResolvedjasonbcoxT605 Backport Core PR 12630
 ResolvedjasonbcoxT604 Backport Core PR 11904
 ResolvednakihitoT606 Backport Core PR 11017
 ResolvedjasonbcoxT607 Backport Core PR 12422

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
jasonbcox closed subtask T513: Backport Core PR 11365 as Resolved.Jan 29 2019, 23:32
jasonbcox closed subtask T515: Backport Core PR 10449 as Wontfix.Feb 1 2019, 22:01
Fabien mentioned this in D2538: Add Qt tests for wallet spends.Feb 12 2019, 08:29
jasonbcox closed subtask T511: Backport Core PR 10770 as Resolved.Feb 12 2019, 19:15
jasonbcox closed subtask T512: Backport Core PR 10420 as Resolved.Feb 12 2019, 22:44
jasonbcox added a parent task: T541: Backport Core PR10267 to support includeconf.Feb 21 2019, 22:40
jasonbcox updated the task description. (Show Details)Mar 11 2019, 18:50
jasonbcox closed subtask T548: Backport Core PR 11809 as Resolved.Mar 12 2019, 16:35
jasonbcox closed subtask T550: Backport Core PR 11039 as Resolved.Mar 16 2019, 15:47
jasonbcox closed subtask T556: Backport Core PR 12327 as Resolved.
jasonbcox added a parent task: T558: Backport Core PR 12830.Mar 18 2019, 19:06
jasonbcox mentioned this in D2133: Move shared qt/bitcoind initialization steps to shared functions..Mar 20 2019, 01:33
nakihito closed subtask T557: Backport Core PR 11733 as Resolved.Mar 22 2019, 18:25
nakihito closed subtask T559: Backport Core PR 10964 as Resolved.
Fabien mentioned this in D2736: [qa] Ensure bitcoind processes are cleaned up when tests end.Mar 26 2019, 08:59
jasonbcox added a parent task: T571: Backport Core PR 10973.Mar 27 2019, 16:25
jasonbcox closed subtask T549: Backport Core PR 10742 as Resolved.Apr 2 2019, 20:29
jasonbcox closed subtask T517: Backport Core PR 9680 as Resolved.Apr 4 2019, 18:23
nakihito mentioned this in T575: Backport Core PR 14532: reduce attack surface of RPC server.Apr 9 2019, 00:04
nakihito added a parent task: T583: Backport Core PR 13190.Apr 9 2019, 18:33
jasonbcox closed subtask T588: Backport Core PR 10368 as Resolved.Apr 10 2019, 22:48
nakihito added a parent task: T590: Backport Core 14555: Move util files to new directory.Apr 12 2019, 17:02
nakihito added a parent task: T592: Backport Core PR 14437: Refactor: Start to separate wallet from node.Apr 12 2019, 23:09
nakihito removed a parent task: T592: Backport Core PR 14437: Refactor: Start to separate wallet from node.
nakihito added a parent task: T595: Backport Core PR15639: bitcoin-wallet tool: Drop libbitcoin_server.a dependency.Apr 15 2019, 18:10
nakihito removed a parent task: T595: Backport Core PR15639: bitcoin-wallet tool: Drop libbitcoin_server.a dependency.Apr 15 2019, 18:12
jasonbcox closed subtask T560: Backport Core PR 11041 as Resolved.Apr 15 2019, 22:39
nakihito closed subtask T599: Backport Core PR 3716: GUI: Receive: Remove option to reuse a previous address as Resolved.Apr 15 2019, 22:45
jasonbcox mentioned this in D2811: Refactor: separate gui from wallet and node.Apr 16 2019, 22:49
jasonbcox closed subtask T604: Backport Core PR 11904 as Resolved.Apr 17 2019, 00:14
jasonbcox closed subtask T605: Backport Core PR 12630 as Resolved.Apr 17 2019, 15:07
jasonbcox mentioned this in D2813: Remove direct bitcoin calls from qt/bitcoin.cpp.Apr 17 2019, 15:59
jasonbcox mentioned this in D2814: Remove direct bitcoin calls from qt/optionsmodel.cpp.Apr 17 2019, 16:23
jasonbcox mentioned this in D2815: Remove direct bitcoin calls from qt/bitcoingui.cpp.Apr 17 2019, 16:49
jasonbcox mentioned this in D2816: Remove direct bitcoin calls from qt/utilitydialog.cpp.Apr 17 2019, 17:12
jasonbcox mentioned this in D2817: Remove direct bitcoin calls from qt/splashscreen.cpp.Apr 17 2019, 17:29
jasonbcox mentioned this in D2818: Remove direct bitcoin calls from qt/clientmodel.cpp.Apr 17 2019, 18:25
jasonbcox mentioned this in D2819: Remove direct bitcoin calls from qt/intro.cpp.Apr 17 2019, 18:54
jasonbcox mentioned this in rABCce73c1b1e925: Remove direct bitcoin calls from qt/bitcoin.cpp.Apr 17 2019, 18:59
jasonbcox mentioned this in rABCabe5b965ab11: Remove direct bitcoin calls from qt/optionsmodel.cpp.
jasonbcox mentioned this in rABC767c84e6195a: Remove direct bitcoin calls from qt/bitcoingui.cpp.Apr 17 2019, 19:02
jasonbcox mentioned this in D2821: Remove direct bitcoin calls from qt/peertablemodel.cpp.Apr 17 2019, 23:10
jasonbcox mentioned this in D2822: Remove direct bitcoin calls from qt/bantablemodel.cpp.Apr 17 2019, 23:23
jasonbcox mentioned this in D2826: Move interface -> interfaces.Apr 18 2019, 16:48
nakihito added a parent task: T598: Backport Core PR 12909: wallet: Make fee settings to be non-static members.Apr 19 2019, 18:54
jasonbcox mentioned this in rABCfb9cfdfcfbf3: Move interface -> interfaces.Apr 19 2019, 19:44
jasonbcox mentioned this in rABCd166b08cb29b: Remove direct bitcoin calls from qt/utilitydialog.cpp.Apr 19 2019, 20:04
jasonbcox mentioned this in D2845: Remove direct bitcoin calls from qt/rpcconsole.cpp.Apr 19 2019, 23:29
jasonbcox mentioned this in rABC916ce3b5660d: Remove direct bitcoin calls from qt/splashscreen.cpp.Apr 23 2019, 21:20
jasonbcox mentioned this in rABCd5744ecaae97: Remove direct bitcoin calls from qt/clientmodel.cpp.Apr 23 2019, 21:35
jasonbcox mentioned this in rABC23f2b13cbdb8: Remove direct bitcoin calls from qt/intro.cpp.Apr 23 2019, 22:02
jasonbcox mentioned this in rABC11a062c29019: Remove direct bitcoin calls from qt/peertablemodel.cpp.Apr 23 2019, 22:06
jasonbcox mentioned this in rABCcdbb52ef348b: Remove direct bitcoin calls from qt/bantablemodel.cpp.Apr 23 2019, 22:23
jasonbcox mentioned this in rABC966fcf6ef3b0: Remove direct bitcoin calls from qt/rpcconsole.cpp.Apr 23 2019, 22:30
jasonbcox mentioned this in D2871: Remove direct bitcoin calls from qt/optionsdialog.cpp.Apr 24 2019, 00:01
jasonbcox mentioned this in D2874: Remove most direct bitcoin calls from qt/walletmodel.cpp.Apr 24 2019, 20:35
jasonbcox mentioned this in rABC19a1f8da0135: Remove direct bitcoin calls from qt/optionsdialog.cpp.Apr 26 2019, 21:57
jasonbcox mentioned this in rABCb2b842fed456: Remove most direct bitcoin calls from qt/walletmodel.cpp.Apr 26 2019, 22:52
jasonbcox mentioned this in D2884: Remove direct bitcoin calls from qt/coincontroldialog.cpp.Apr 28 2019, 16:34
jasonbcox mentioned this in D2885: Remove direct bitcoin calls from qt/addresstablemodel.cpp.Apr 29 2019, 16:00
jasonbcox mentioned this in rABCdb889a6b6b62: Remove direct bitcoin calls from qt/coincontroldialog.cpp.Apr 29 2019, 16:18
jasonbcox mentioned this in D2886: Remove direct bitcoin calls from qt/paymentserver.cpp.Apr 29 2019, 17:00
jasonbcox mentioned this in D2887: Remove direct bitcoin calls from qt transaction table files.Apr 29 2019, 18:46
jasonbcox mentioned this in D2888: Remove direct bitcoin access from qt/guiutil.cpp.Apr 29 2019, 19:23
jasonbcox mentioned this in D2889: Remove direct bitcoin calls from qt/sendcoinsdialog.cpp.Apr 29 2019, 22:28
jasonbcox mentioned this in rABC02fb9f37a5bc: Remove direct bitcoin calls from qt/addresstablemodel.cpp.Apr 30 2019, 16:14
jasonbcox mentioned this in rABCca3673a14298: Remove direct bitcoin calls from qt/paymentserver.cpp.May 1 2019, 15:53
jasonbcox mentioned this in rABCd80fb0a9f1e3: Remove direct bitcoin calls from qt transaction table files.May 1 2019, 15:57
jasonbcox mentioned this in rABC305e6ce34d6e: Remove direct bitcoin access from qt/guiutil.cpp.May 1 2019, 16:01
jasonbcox mentioned this in D2899: Use WalletBalances struct in Qt.May 2 2019, 00:03
jasonbcox mentioned this in D2900: Add developer notes about blocking GUI code and src/interfaces/README.md.May 2 2019, 00:21
jasonbcox mentioned this in rABCe63967b50b8e: Remove direct bitcoin calls from qt/sendcoinsdialog.cpp.May 2 2019, 14:48
jasonbcox mentioned this in rABC23a0cd463cfe: Use WalletBalances struct in Qt.May 2 2019, 20:04
jasonbcox mentioned this in rABC9dfd6fbb3272: Add developer notes about blocking GUI code and src/interfaces/README.md.May 6 2019, 15:45
jasonbcox closed this task as Resolved.May 6 2019, 15:45
Fabien mentioned this in D2968: qt: refactor: Changes to make include paths absolute.May 7 2019, 14:09
Fabien mentioned this in rABC475a1a34915f: qt: refactor: Changes to make include paths absolute.May 8 2019, 09:47
markblundeberg mentioned this in D3133: SegWit wallet support.May 28 2019, 02:06
jasonbcox mentioned this in rSTAGINGce73c1b1e925: Remove direct bitcoin calls from qt/bitcoin.cpp.Sep 18 2019, 23:00
jasonbcox mentioned this in rSTAGINGabe5b965ab11: Remove direct bitcoin calls from qt/optionsmodel.cpp.
jasonbcox mentioned this in rSTAGING767c84e6195a: Remove direct bitcoin calls from qt/bitcoingui.cpp.
jasonbcox mentioned this in rSTAGINGfb9cfdfcfbf3: Move interface -> interfaces.Sep 18 2019, 23:02
jasonbcox mentioned this in rSTAGINGd166b08cb29b: Remove direct bitcoin calls from qt/utilitydialog.cpp.
jasonbcox mentioned this in rSTAGINGd5744ecaae97: Remove direct bitcoin calls from qt/clientmodel.cpp.Sep 18 2019, 23:07
jasonbcox mentioned this in rSTAGING916ce3b5660d: Remove direct bitcoin calls from qt/splashscreen.cpp.
jasonbcox mentioned this in rSTAGING23f2b13cbdb8: Remove direct bitcoin calls from qt/intro.cpp.
jasonbcox mentioned this in rSTAGING11a062c29019: Remove direct bitcoin calls from qt/peertablemodel.cpp.
jasonbcox mentioned this in rSTAGINGcdbb52ef348b: Remove direct bitcoin calls from qt/bantablemodel.cpp.
jasonbcox mentioned this in rSTAGING966fcf6ef3b0: Remove direct bitcoin calls from qt/rpcconsole.cpp.
jasonbcox mentioned this in rSTAGINGb2b842fed456: Remove most direct bitcoin calls from qt/walletmodel.cpp.Sep 18 2019, 23:09
jasonbcox mentioned this in rSTAGING19a1f8da0135: Remove direct bitcoin calls from qt/optionsdialog.cpp.
jasonbcox mentioned this in rSTAGINGdb889a6b6b62: Remove direct bitcoin calls from qt/coincontroldialog.cpp.
jasonbcox mentioned this in rSTAGING02fb9f37a5bc: Remove direct bitcoin calls from qt/addresstablemodel.cpp.
jasonbcox mentioned this in rSTAGINGd80fb0a9f1e3: Remove direct bitcoin calls from qt transaction table files.
jasonbcox mentioned this in rSTAGINGca3673a14298: Remove direct bitcoin calls from qt/paymentserver.cpp.
jasonbcox mentioned this in rSTAGING305e6ce34d6e: Remove direct bitcoin access from qt/guiutil.cpp.
jasonbcox mentioned this in rSTAGINGe63967b50b8e: Remove direct bitcoin calls from qt/sendcoinsdialog.cpp.Sep 18 2019, 23:11
jasonbcox mentioned this in rSTAGING23a0cd463cfe: Use WalletBalances struct in Qt.
jasonbcox mentioned this in rSTAGING9dfd6fbb3272: Add developer notes about blocking GUI code and src/interfaces/README.md.Sep 18 2019, 23:16
Fabien mentioned this in rSTAGING475a1a34915f: qt: refactor: Changes to make include paths absolute.Sep 18 2019, 23:20