Page MenuHomePhabricator
Differential D2900

Add developer notes about blocking GUI code and src/interfaces/README.md
ClosedPublic
Actions

Authored by jasonbcox on May 2 2019, 00:21.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING9dfd6fbb3272: Add developer notes about blocking GUI code and src/interfaces/README.md
rABC9dfd6fbb3272: Add developer notes about blocking GUI code and src/interfaces/README.md
Summary

Partial backport of Core PR 10244 (remaining documentation changes)
https://github.com/bitcoin/bitcoin/pull/10244/commits/996013769711bd507cdcd6dde88cbd59fcd4fbad
https://github.com/bitcoin/bitcoin/pull/10244/commits/ea73b84d2ddde22487dee0f71d7a619051e067f2
Completes T417

Test Plan

Read it

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox created this revision.May 2 2019, 00:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 2 2019, 00:21
teamcity added a comment.May 2 2019, 00:21

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox added inline comments.May 2 2019, 00:22
src/interfaces/README.md
7 ↗(On Diff #8332)

I don't want to fuck with re-backporting these two lines, but I'm pointing out that chain.h doesn't actually exist yet. The link(s) point to PRs that hadn't been merged in yet (and wouldn't be until many months later).

teamcity added a comment.May 2 2019, 00:35

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5641: Diff 8332.May 2 2019, 00:35
Fabien requested changes to this revision.May 2 2019, 06:18
Fabien added inline comments.
src/interfaces/README.md
15 ↗(On Diff #8332)

This one doesn't exist either, and is not merged by core; I think you can remove it.

This revision now requires changes to proceed.May 2 2019, 06:18
jasonbcox updated this revision to Diff 8347.May 2 2019, 20:09

Removed init.h since it won't even exist in the near future

teamcity added a comment.May 2 2019, 20:10

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 2 2019, 20:24

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5652: Diff 8347.May 2 2019, 20:24
Fabien accepted this revision.May 4 2019, 09:52
This revision is now accepted and ready to land.May 4 2019, 09:52
Closed by commit rABC9dfd6fbb3272: Add developer notes about blocking GUI code and src/interfaces/README.md (authored by Russell Yanofsky <russ@yanofsky.org>, committed by jasonbcox). · Explain WhyMay 6 2019, 15:45
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rSTAGING9dfd6fbb3272: Add developer notes about blocking GUI code and src/interfaces/README.md.Sep 18 2019, 23:16

Revision Contents
Changeset List

PathSize
doc/
13 lines
src/
interfaces/
15 lines

Diff 8416

View Options

doc/developer-notes.md

Loading...
View Options

src/interfaces/README.md

Loading...