Differential D2811

Refactor: separate gui from wallet and node
AbandonedPublic
Actions

Authored by jasonbcox on Apr 16 2019, 22:49.

Tags

None

Subscribers

Details

Reviewers

deadalnix
Fabien

Group Reviewers

Restricted Project

Summary

Remove direct bitcoin calls from qt/bitcoin.cpp
Remove direct bitcoin calls from qt/optionsmodel.cpp
Remove direct bitcoin calls from qt/bitcoingui.cpp
Remove direct bitcoin calls from qt/utilitydialog.cpp
Remove direct bitcoin calls from qt/splashscreen.cpp
Remove direct bitcoin calls from qt/clientmodel.cpp
Remove direct bitcoin calls from qt/intro.cpp
Remove direct bitcoin calls from qt/peertablemodel.cpp
Remove direct bitcoin calls from qt/bantablemodel.cpp
Remove direct bitcoin calls from qt/rpcconsole.cpp
Remove direct bitcoin calls from qt/optionsdialog.cpp
Remove most direct bitcoin calls from qt/walletmodel.cpp
Remove direct bitcoin calls from qt/coincontroldialog.cpp
Remove direct bitcoin calls from qt/addresstablemodel.cpp
Remove direct bitcoin calls from qt/paymentserver.cpp
Remove direct bitcoin calls from qt transaction table files

Backport of Core PR 10244 (reviewer warning: this PR is massive)
https://github.com/bitcoin/bitcoin/pull/10244/files
Completes T417
Depends on D2810 and approximately 50+ diffs already landed on master

Test Plan

make check
test_runner.py

# Check bitcoin-qt for sanity checks:
# * does not crash
# * can send and receive txs as expected
# * balance displays as expected
# * past tx records display as expected
bitcoin-qt

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr10244-4

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5476
Build 9014: Bitcoin ABC Buildbot (legacy)
Build 9013: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Apr 16 2019, 22:49

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 16 2019, 22:49

jasonbcox planned changes to this revision.Apr 16 2019, 22:50

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Macro itsoveritsdone:

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5476: Diff 8086.Apr 16 2019, 23:06

Macro sobig:

Congrats

Abandoning in favor of smaller diffs.

Revision Contents
Changeset List

Path

Size

src/

3 lines

7 lines

Makefile.qt.include

4 lines

Makefile.qttest.include

2 lines

interface/

34 lines

32 lines

258 lines

320 lines

337 lines

421 lines

net_processing.h

6 lines

qt/

addresstablemodel.h

7 lines

addresstablemodel.cpp

80 lines

bantablemodel.h

7 lines

bantablemodel.cpp

11 lines

110 lines

13 lines

42 lines

38 lines

clientmodel.cpp

174 lines

coincontroldialog.cpp

84 lines

6 lines

7 lines

optionsdialog.cpp

7 lines

12 lines

optionsmodel.cpp

37 lines

overviewpage.cpp

12 lines

paymentserver.h

11 lines

paymentserver.cpp

27 lines

peertablemodel.h

7 lines

peertablemodel.cpp

43 lines

recentrequeststablemodel.h

4 lines

recentrequeststablemodel.cpp

4 lines

19 lines

76 lines

sendcoinsdialog.cpp

18 lines

signverifymessagedialog.cpp

2 lines

21 lines

splashscreen.cpp

48 lines

test/

paymentservertests.cpp

6 lines

rpcnestedtests.cpp

138 lines

wallettests.cpp

11 lines

trafficgraphwidget.cpp

13 lines

transactiondesc.h

15 lines

transactiondesc.cpp

185 lines

transactionrecord.h

19 lines

transactionrecord.cpp

110 lines

transactiontablemodel.h

13 lines

transactiontablemodel.cpp

114 lines

transactionview.cpp

8 lines

utilitydialog.h

7 lines

utilitydialog.cpp

6 lines

66 lines

walletmodel.cpp

352 lines

walletmodeltransaction.h

15 lines

walletmodeltransaction.cpp

21 lines

6 lines

3 lines

3 lines

wallet/

1 line

Diff 8086

src/CMakeLists.txt

Loading...

src/Makefile.am

Loading...

src/Makefile.qt.include

Loading...

src/Makefile.qttest.include

Loading...

src/interface/handler.h

Loading...

src/interface/handler.cpp

Loading...

src/interface/node.h

Loading...

src/interface/node.cpp

Loading...

src/interface/wallet.h

Loading...

src/interface/wallet.cpp

Loading...

src/net_processing.h

Loading...

src/qt/addresstablemodel.h

Loading...

src/qt/addresstablemodel.cpp

Loading...

src/qt/bantablemodel.h

Loading...

src/qt/bantablemodel.cpp

Loading...

src/qt/bitcoin.cpp

Loading...

src/qt/bitcoingui.h

Loading...

src/qt/bitcoingui.cpp

Loading...

src/qt/clientmodel.h

Loading...

src/qt/clientmodel.cpp

Loading...

src/qt/coincontroldialog.cpp

Loading...

src/qt/intro.h

Loading...

src/qt/intro.cpp

Loading...

src/qt/optionsdialog.cpp

Loading...

src/qt/optionsmodel.h

Loading...

src/qt/optionsmodel.cpp

Loading...

src/qt/overviewpage.cpp

Loading...

src/qt/paymentserver.h

Loading...

src/qt/paymentserver.cpp

Loading...

src/qt/peertablemodel.h

Loading...

src/qt/peertablemodel.cpp

Loading...

src/qt/recentrequeststablemodel.h

Loading...

src/qt/recentrequeststablemodel.cpp

Loading...

src/qt/rpcconsole.h

Loading...

src/qt/rpcconsole.cpp

Loading...

src/qt/sendcoinsdialog.cpp

Loading...

src/qt/signverifymessagedialog.cpp

Loading...

src/qt/splashscreen.h

Loading...

src/qt/splashscreen.cpp

Loading...

src/qt/test/paymentservertests.cpp

Loading...

src/qt/test/rpcnestedtests.cpp

Loading...

src/qt/test/wallettests.cpp

Loading...

src/qt/trafficgraphwidget.cpp

Loading...

src/qt/transactiondesc.h

Loading...

src/qt/transactiondesc.cpp

Loading...

src/qt/transactionrecord.h

Loading...

src/qt/transactionrecord.cpp

Loading...

src/qt/transactiontablemodel.h

Loading...

src/qt/transactiontablemodel.cpp

Loading...

src/qt/transactionview.cpp

Loading...

src/qt/utilitydialog.h

Loading...

src/qt/utilitydialog.cpp

Loading...

src/qt/walletmodel.h

Loading...

src/qt/walletmodel.cpp

Loading...

src/qt/walletmodeltransaction.h

Loading...

src/qt/walletmodeltransaction.cpp

Loading...

src/qt/walletview.cpp

Loading...

src/validation.h

Loading...

src/validation.cpp

Loading...

src/wallet/CMakeLists.txt

Loading...