[wallet] Close DB on error.
ClosedPublic
Actions

Authored by nakihito on Apr 16 2019, 19:29.

Details

Reviewers

jasonbcox
deadalnix
Fabien

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGINGbcaab422dcc8: [wallet] Close DB on error.
rABCbcaab422dcc8: [wallet] Close DB on error.

Summary

[wallet] Close DB on error.

Backport of Core PR 11017
https://github.com/bitcoin/bitcoin/pull/11017

Completes T606

Test Plan

make check
test_runner.py
Sanity check open and close (both by exiting and by ctrl-C interrupt) bitcoin-qt

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

nakihito created this revision.Apr 16 2019, 19:29

Owners added a reviewer: Restricted Owners Package.Apr 16 2019, 19:29

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 16 2019, 19:29

nakihito edited the test plan for this revision. (Show Details)Apr 16 2019, 19:31

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox added inline comments.Apr 16 2019, 19:38

src/wallet/db.cpp
618 ↗	(On Diff #8076)	Note to reviewers: `delete pdbCopy;` is no longer necessary here since pdbCopy was migrated to use unique_ptr (out of order backport in D2229)

nakihito edited the test plan for this revision. (Show Details)Apr 16 2019, 19:38

nakihito edited the test plan for this revision. (Show Details)Apr 16 2019, 19:41

jasonbcox accepted this revision.Apr 16 2019, 19:41

This revision is now accepted and ready to land.Apr 16 2019, 19:41

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5468: Diff 8076.Apr 16 2019, 19:45

Closed by commit rABCbcaab422dcc8: [wallet] Close DB on error. (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>, committed by nakihito). · Explain WhyApr 16 2019, 19:46

This revision was automatically updated to reflect the committed changes.

jasonbcox added a child revision: D2808: Merge #11904: Add a lock to the wallet directory.Apr 16 2019, 20:06

Nico Guiton <nico@bitframe.org> added a commit: rSTAGINGbcaab422dcc8: [wallet] Close DB on error..Sep 18 2019, 22:58

Revision Contents
Changeset List

Path

Size

src/

wallet/

db.cpp

4 lines

Diff 8077

View Options

[wallet] Close DB on error.ClosedPublicActions