Page MenuHomePhabricator

Use unique_ptr for pwalletMain,httpRPCTimerInterface,dbw,dbenv,pdbCopy

Authored by Fabien on Dec 28 2018, 15:52.



Partial backport of core PR11043

The following commits from this PR are backported:

  • 860e912, 5a6f768, 0024531, 29ab96d, b45c597 in this diff
  • 8ccf1bb, f72cbf9 in D1769
  • d223bc9 in D1910

73db063 is no longer needed since D1765


  • fa6d122 for fees in TxConfirmStats
  • 8617989, 3e09b39, a357293 to introduce MakeUnique (later diff)
Test Plan
make check

Diff Detail

rABC Bitcoin ABC
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Dec 28 2018, 15:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 28 2018, 15:52
Herald added a subscriber: schancel. · View Herald Transcript
Fabien updated this revision to Diff 6441.Dec 28 2018, 23:02


deadalnix accepted this revision.Dec 30 2018, 18:59
This revision is now accepted and ready to land.Dec 30 2018, 18:59
Closed by commit rABC6c2476a5c9ed: Use unique_ptr for pwalletMain,httpRPCTimerInterface,dbw,dbenv,pdbCopy (authored by practicalswift <>, committed by Fabien). · Explain WhyDec 31 2018, 13:18
This revision was automatically updated to reflect the committed changes.