Page MenuHomePhabricator
Differential D2229

Use unique_ptr for pwalletMain,httpRPCTimerInterface,dbw,dbenv,pdbCopy
ClosedPublic
Actions

Authored by Fabien on Dec 28 2018, 15:52.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING6c2476a5c9ed: Use unique_ptr for pwalletMain,httpRPCTimerInterface,dbw,dbenv,pdbCopy
rABC6c2476a5c9ed: Use unique_ptr for pwalletMain,httpRPCTimerInterface,dbw,dbenv,pdbCopy
Summary

Partial backport of core PR11043

The following commits from this PR are backported:

  • 860e912, 5a6f768, 0024531, 29ab96d, b45c597 in this diff
  • 8ccf1bb, f72cbf9 in D1769
  • d223bc9 in D1910

73db063 is no longer needed since D1765

Remaining:

  • fa6d122 for fees in TxConfirmStats
  • 8617989, 3e09b39, a357293 to introduce MakeUnique (later diff)
Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Dec 28 2018, 15:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 28 2018, 15:52
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Dec 28 2018, 15:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B4372: Diff 6436.Dec 28 2018, 16:02
teamcity added a comment.Dec 28 2018, 16:02

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fabien updated this revision to Diff 6441.Dec 28 2018, 23:02

Rebase

teamcity added a comment.Dec 28 2018, 23:12

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien added a child revision: D2232: Add MakeUnique (substitute for C++14 std::make_unique).Dec 28 2018, 23:13
teamcity added a comment.Dec 28 2018, 23:20

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4375: Diff 6441.Dec 28 2018, 23:20
deadalnix accepted this revision.Dec 30 2018, 18:59
This revision is now accepted and ready to land.Dec 30 2018, 18:59
Closed by commit rABC6c2476a5c9ed: Use unique_ptr for pwalletMain,httpRPCTimerInterface,dbw,dbenv,pdbCopy (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by Fabien). · Explain WhyDec 31 2018, 13:18
This revision was automatically updated to reflect the committed changes.
jasonbcox mentioned this in D2807: [wallet] Close DB on error..Apr 16 2019, 19:38

Revision Contents
Changeset List

PathSize
src/
12 lines
test/
10 lines
wallet/
2 lines
23 lines
test/
12 lines

Diff 6469

View Options

src/httprpc.cpp

Loading...
View Options

src/test/dbwrapper_tests.cpp

Loading...
View Options

src/wallet/db.h

Loading...
View Options

src/wallet/db.cpp

Loading...
View Options

src/wallet/test/wallet_test_fixture.cpp

Loading...