HomePhabricator

Use unique_ptr for pwalletMain,httpRPCTimerInterface,dbw,dbenv,pdbCopy

Description

Use unique_ptr for pwalletMain,httpRPCTimerInterface,dbw,dbenv,pdbCopy

Summary:
Partial backport of core PR11043

The following commits from this PR are backported:

  • 860e912, 5a6f768, 0024531, 29ab96d, b45c597 in this diff
  • 8ccf1bb, f72cbf9 in D1769
  • d223bc9 in D1910

73db063 is no longer needed since D1765

Remaining:

  • fa6d122 for fees in TxConfirmStats
  • 8617989, 3e09b39, a357293 to introduce MakeUnique (later diff)

Test Plan:

make check

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: teamcity, schancel

Differential Revision: https://reviews.bitcoinabc.org/D2229

Details

Committed
FabienDec 31 2018, 13:17
Pushed
FabienDec 31 2018, 13:17
Reviewer
Restricted Project
Differential Revision
D2229: Use unique_ptr for pwalletMain,httpRPCTimerInterface,dbw,dbenv,pdbCopy
Parents
rABC0cfc3cfb9f19: Refactor: make the CDataStream::read function simpler
Branches
Unknown
Tags
Unknown

Event Timeline

Fabien committed rABC6c2476a5c9ed: Use unique_ptr for pwalletMain,httpRPCTimerInterface,dbw,dbenv,pdbCopy (authored by practicalswift <practicalswift@users.noreply.github.com>).Dec 31 2018, 13:17