Page MenuHomePhabricator

[wallet] Close DB on error.
ClosedPublic

Authored by nakihito on Apr 16 2019, 19:29.

Details

Reviewers
jasonbcox
deadalnix
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGbcaab422dcc8: [wallet] Close DB on error.
rABCbcaab422dcc8: [wallet] Close DB on error.
Summary

[wallet] Close DB on error.

Backport of Core PR 11017
https://github.com/bitcoin/bitcoin/pull/11017

Completes T606

Test Plan

make check
test_runner.py
Sanity check open and close (both by exiting and by ctrl-C interrupt) bitcoin-qt

Diff Detail

Repository
rABC Bitcoin ABC
Branch
BackportPR11017
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5468
Build 8998: Bitcoin ABC Buildbot (legacy)
Build 8997: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Apr 16 2019, 19:29
src/wallet/db.cpp
618

Note to reviewers: delete pdbCopy; is no longer necessary here since pdbCopy was migrated to use unique_ptr (out of order backport in D2229)

This revision is now accepted and ready to land.Apr 16 2019, 19:41
This revision was automatically updated to reflect the committed changes.